Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 1975163002: LayoutFullScreen::m_placeholder is LayoutBlockFlow. (Closed)

Created:
4 years, 7 months ago by mstensho (USE GERRIT)
Modified:
4 years, 7 months ago
Reviewers:
szager1, wkorman, eae
CC:
chromium-reviews, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, sof, eae+blinkwatch, leviw+renderwatch, blink-reviews-dom_chromium.org, dglazkov+blink, jchaffraix+rendering, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

LayoutFullScreen::m_placeholder is LayoutBlockFlow. The code calls m_placeholder->beingDestroyed(), which is a method that I believe belongs down in LayoutBlockFlow, not in LayoutBlock. No need for the setter, BTW, so replaced it with resetPlaceholder(). BUG=302024 Committed: https://crrev.com/cec7a0540e30913163dc66f7eba914b1ead71da4 Cr-Commit-Position: refs/heads/master@{#393545}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -10 lines) Patch
M third_party/WebKit/Source/core/dom/Fullscreen.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFullScreen.h View 3 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFullScreen.cpp View 2 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mstensho (USE GERRIT)
4 years, 7 months ago (2016-05-13 14:10:39 UTC) #2
eae
LGTM
4 years, 7 months ago (2016-05-13 16:26:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1975163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1975163002/1
4 years, 7 months ago (2016-05-13 16:26:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-13 16:33:16 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 16:34:49 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cec7a0540e30913163dc66f7eba914b1ead71da4
Cr-Commit-Position: refs/heads/master@{#393545}

Powered by Google App Engine
This is Rietveld 408576698