Enable NativeActivity based Android tests.

testing/android/native_test/java/src/org/chromium/native_test/NativeUnitTestActivity.java

Index: testing/android/native_test/java/src/org/chromium/native_test/NativeUnitTestActivity.java
diff --git a/testing/android/native_test/java/src/org/chromium/native_test/NativeUnitTestActivity.java b/testing/android/native_test/java/src/org/chromium/native_test/NativeUnitTestActivity.java
index 84115838972fbedbc8e6b056cfc1ded075cdfca5..bd1a8ca808fdcbfc7df3085bb3800c3dbcf3ae64 100644
--- a/testing/android/native_test/java/src/org/chromium/native_test/NativeUnitTestActivity.java
+++ b/testing/android/native_test/java/src/org/chromium/native_test/NativeUnitTestActivity.java
@@ -17,6 +17,11 @@ import org.chromium.base.library_loader.NativeLibraries;
  * (i.e., not browser tests)
  */
 public class NativeUnitTestActivity extends NativeTestActivity {
+    static {
+        // For NativeActivity based tests
+        // dependency libraries must be loaded before NativeActivity::OnCreate

[Yaron, 2016/05/20 14:39:54]

Can you elaborate (to me, not comments) why this is necessary? I'd like to avoid
it

[agrieve, 2016/05/20 15:43:16]

I think what's going on here is that NativeActivity calls through to JNI in its
onCreate:
https://github.com/android/platform_frameworks_base/blob/master/core/java/and...

It's meant so that you don't need to write any .java, and NativeActivity loads
your library via the android.app.lib_name metadata in the manifest. However,
here we still manually load the libraries so that component mode will work.

So yeah, I think just calling it before super.onCreate() will work out.

[ynovikov, 2016/05/20 17:07:38]

You are right, but it's a bit more complicated. NativeActivity loads
android.app.lib_name in NativeActivity::onCreate. However, Android / Java
dependency search path is limited to /system/lib. We have dependencies in the
apk, for example all our libraries depend on libc++_shared.so. For ANGLE tests,
they will also depend on ANGLE's GLES / EGL libs. If those dependencies are not
preloaded, loading in NativeActivity::onCreate will fail. I think it should be
OK to load the dependencies before super.onCreate(), if you prefer it this way.

[Yaron, 2016/05/20 17:54:42]

sure, ok to move to onCreate and before super.oncreate

[ynovikov, 2016/05/26 03:16:15]

Done.

+        loadLibraries();
+    }
 
     private static final String TAG = "cr_NativeTest";
 
@@ -31,15 +36,14 @@ public class NativeUnitTestActivity extends NativeTestActivity {
         PowerMonitor.createForTests(this);
 
         ContextUtils.initApplicationContext(getApplicationContext());
-        loadLibraries();
+        ContextUtils.initApplicationContextForNative();
     }
 
-    private void loadLibraries() {
+    private static void loadLibraries() {
         for (String library : NativeLibraries.LIBRARIES) {
             Log.i(TAG, "loading: %s", library);
             System.loadLibrary(library);
             Log.i(TAG, "loaded: %s", library);
         }
-        ContextUtils.initApplicationContextForNative();
     }
 }