 Chromium Code Reviews
 Chromium Code Reviews Issue 1975153003:
  Enable NativeActivity based Android tests.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master
    
  
    Issue 1975153003:
  Enable NativeActivity based Android tests.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: testing/test.gni | 
| diff --git a/testing/test.gni b/testing/test.gni | 
| index c01306c644880a3b574cda10aec1445640e51451..1caad5dc9d02ee7b10af667720f4644747f5c86e 100644 | 
| --- a/testing/test.gni | 
| +++ b/testing/test.gni | 
| @@ -63,6 +63,7 @@ template("_gen_isolate") { | 
| # set. | 
| # Variable: | 
| # use_raw_android_executable: Use executable() rather than android_apk(). | 
| +# use_native_activity: Test implements ANativeActivity_onCreate(). | 
| template("test") { | 
| if (is_android) { | 
| import("//build/config/android/config.gni") | 
| @@ -153,6 +154,8 @@ template("test") { | 
| } | 
| } | 
| } else { | 
| + _use_native_activity = | 
| + defined(invoker.use_native_activity) && invoker.use_native_activity | 
| 
agrieve
2016/05/19 00:42:51
nit: it's a bit less code to just add "use_native_
 
ynovikov
2016/05/20 02:38:10
Done.
 | 
| _library_target = "_${target_name}__library" | 
| _apk_target = "${target_name}_apk" | 
| _apk_specific_vars = [ | 
| @@ -180,6 +183,7 @@ template("test") { | 
| } | 
| unittest_apk(_apk_target) { | 
| forward_variables_from(invoker, _apk_specific_vars + [ "deps" ]) | 
| + use_native_activity = _use_native_activity | 
| unittests_dep = ":$_library_target" | 
| apk_name = invoker.target_name | 
| if (defined(invoker.output_name)) { |