Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 1975133004: Switch to using resolverWorld from codegenWorld to determine whether JS interop interceptors need t… (Closed)

Created:
4 years, 7 months ago by Jacob
Modified:
4 years, 7 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Switch to using resolverWorld from codegenWorld to determine whether JS interop interceptors need to be generated as codegenWorld is incorrectly reporting that some JS interop methods are not invoked even when they are. BUG= R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/07cc57d1102892dc0295a32b2d92c124e8f3bbc2

Patch Set 1 #

Total comments: 2

Patch Set 2 : ptal #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart View 1 4 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jacob
4 years, 7 months ago (2016-05-13 23:44:46 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/1975133004/diff/1/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart File pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart (right): https://codereview.chromium.org/1975133004/diff/1/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart#newcode351 pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart:351: _compiler.resolverWorld.getterInvocationsByName(member.name); let's add a TODO + reference to ...
4 years, 7 months ago (2016-05-13 23:46:53 UTC) #3
Jacob
https://codereview.chromium.org/1975133004/diff/1/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart File pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart (right): https://codereview.chromium.org/1975133004/diff/1/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart#newcode351 pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart:351: _compiler.resolverWorld.getterInvocationsByName(member.name); On 2016/05/13 23:46:53, Siggi Cherem (dart-lang) wrote: > ...
4 years, 7 months ago (2016-05-13 23:55:35 UTC) #4
Jacob
4 years, 7 months ago (2016-05-14 00:20:24 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
07cc57d1102892dc0295a32b2d92c124e8f3bbc2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698