Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 197513005: Deprecate Start/StopCpuProfiling methods (Closed)

Created:
6 years, 9 months ago by yurys
Modified:
6 years, 9 months ago
Reviewers:
Sven Panne, alph, loislo
CC:
v8-dev, Paweł Hajdan Jr.
Visibility:
Public.

Description

Deprecate Start/StopCpuProfiling methods BUG=v8:3213 LOG=Y R=alph@chromium.org, svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20325

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -58 lines) Patch
M include/v8-profiler.h View 2 chunks +5 lines, -2 lines 0 comments Download
M test/cctest/profiler-extension.h View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/profiler-extension.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-cpu-profiler.cc View 32 chunks +49 lines, -51 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
yurys
6 years, 9 months ago (2014-03-18 15:25:20 UTC) #1
yurys
6 years, 9 months ago (2014-03-21 07:31:54 UTC) #2
alph
lgtm
6 years, 9 months ago (2014-03-24 12:14:01 UTC) #3
Sven Panne
lgtm
6 years, 9 months ago (2014-03-28 09:01:09 UTC) #4
yurys
6 years, 9 months ago (2014-03-28 09:24:59 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r20325 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698