Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: chromeos/ime/xkeyboard.cc

Issue 197513004: xkb: XkbNamesPtr::vmods is an array (of atoms). It doesn't make sense to null check the array. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/ime/xkeyboard.cc
diff --git a/chromeos/ime/xkeyboard.cc b/chromeos/ime/xkeyboard.cc
index 7714e20b241ed9dc6480628dcc211be8c0552e6f..e0e69cfd4c919ba670df73ea000b8a0d62a213dc 100644
--- a/chromeos/ime/xkeyboard.cc
+++ b/chromeos/ime/xkeyboard.cc
@@ -153,7 +153,7 @@ unsigned int XKeyboardImpl::GetNumLockMask() {
if (!xkb_desc)
return kBadMask;
- if (xkb_desc->dpy && xkb_desc->names && xkb_desc->names->vmods) {
+ if (xkb_desc->dpy && xkb_desc->names) {
const std::string string_to_find(kNumLockVirtualModifierString);
for (size_t i = 0; i < XkbNumVirtualMods; ++i) {
const unsigned int virtual_mod_mask = 1U << i;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698