Issue 197513004: xkb: XkbNamesPtr::vmods is an array (of atoms). It doesn't make sense to null check the array.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 197513004: xkb: XkbNamesPtr::vmods is an array (of atoms). It doesn't make sense to null check the array. (Closed)

Created:
6 years, 9 months ago by sadrul

Modified:
6 years, 9 months ago

Reviewers:
Yusuke Sato, Daniel Erat

CC:
chromium-reviews, nona+watch_chromium.org, stevenjb+watch_chromium.org, yusukes+watch_chromium.org, oshima+watch_chromium.org, yukishiino+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

xkb: XkbNamesPtr::vmods is an array (of atoms). It doesn't make sense to null check the array. BUG=none R=derat@chromium.org, yusukes@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257775

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chromeos/ime/xkeyboard.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

sadrul

Hi! The CL that originally added this code is: https://codereview.chromium.org/8356040 Mind reviewing this quick fix? ...

6 years, 9 months ago (2014-03-18 11:34:01 UTC) #1

Yusuke Sato

On 2014/03/18 14:21:10, sadrul wrote: > +derat@ for owner lgtm

6 years, 9 months ago (2014-03-18 16:04:21 UTC) #3

sadrul

6 years, 9 months ago (2014-03-18 21:59:06 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r257775 (presubmit successful).

Expand Messages | Collapse Messages