Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1975113002: Adding expectations for failing Nexus 5X tests. (Closed)

Created:
4 years, 7 months ago by cblume
Modified:
4 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding expectations for failing Nexus 5X tests. The following tests were failing on the Nexus 5X bot: WebglConformance.conformance_textures_image_data_tex_2d_rgb_rgb_unsigned_byte WebglConformance.conformance_textures_image_data_tex_2d_rgb_rgb_unsigned_short_5_6_5 WebglConformance.conformance_textures_image_data_tex_2d_rgba_rgba_unsigned_byte WebglConformance.conformance_textures_image_data_tex_2d_rgba_rgba_unsigned_short_4_4_4_4 WebglConformance.conformance_textures_image_data_tex_2d_rgba_rgba_unsigned_short_5_5_5_1 WebglConformance.conformance_textures_svg_image_tex_2d_rgb_rgb_unsigned_byte WebglConformance.conformance_textures_svg_image_tex_2d_rgb_rgb_unsigned_short_5_6_5 WebglConformance.conformance_textures_svg_image_tex_2d_rgba_rgba_unsigned_byte WebglConformance.conformance_textures_svg_image_tex_2d_rgba_rgba_unsigned_short_4_4_4_4 WebglConformance.conformance_textures_svg_image_tex_2d_rgba_rgba_unsigned_short_5_5_5_1 WebglConformance.conformance_textures_video_tex_2d_rgb_rgb_unsigned_byte BUG=610951, 490984 R=kbr@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/6408b4bf38bc155ddf5864bbd37f72d276c57761 Cr-Commit-Position: refs/heads/master@{#393659}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Explicitly specifying tests instead of using *. Fixing expectation collision. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -0 lines) Patch
M content/test/gpu/gpu_tests/webgl_conformance_expectations.py View 1 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1975113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1975113002/1
4 years, 7 months ago (2016-05-13 10:11:51 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-13 11:14:31 UTC) #5
Ken Russell (switch to Gerrit)
lgtm with small update https://codereview.chromium.org/1975113002/diff/1/content/test/gpu/gpu_tests/webgl_conformance_expectations.py File content/test/gpu/gpu_tests/webgl_conformance_expectations.py (right): https://codereview.chromium.org/1975113002/diff/1/content/test/gpu/gpu_tests/webgl_conformance_expectations.py#newcode124 content/test/gpu/gpu_tests/webgl_conformance_expectations.py:124: self.Fail('conformance/textures/image_data/*', It would be better ...
4 years, 7 months ago (2016-05-13 18:00:52 UTC) #6
cblume
https://codereview.chromium.org/1975113002/diff/1/content/test/gpu/gpu_tests/webgl_conformance_expectations.py File content/test/gpu/gpu_tests/webgl_conformance_expectations.py (right): https://codereview.chromium.org/1975113002/diff/1/content/test/gpu/gpu_tests/webgl_conformance_expectations.py#newcode124 content/test/gpu/gpu_tests/webgl_conformance_expectations.py:124: self.Fail('conformance/textures/image_data/*', On 2016/05/13 18:00:52, Ken Russell wrote: > It ...
4 years, 7 months ago (2016-05-13 20:46:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1975113002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1975113002/20001
4 years, 7 months ago (2016-05-13 20:46:27 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-13 22:08:19 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 22:09:18 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6408b4bf38bc155ddf5864bbd37f72d276c57761
Cr-Commit-Position: refs/heads/master@{#393659}

Powered by Google App Engine
This is Rietveld 408576698