Change destination dir of web-platform-tests to wpt.

third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Pull latest revisions of a W3C test repo and make a local commit."""
 
 import argparse
 import re
 
 from webkitpy.common.webkit_finder import WebKitFinder
 
+# Import destination directories (under LayoutTests/imported/).
+WPT_DEST_NAME = 'wpt'
+CSS_DEST_NAME = 'csswg-test'
+
 
 class DepsUpdater(object):
 
     def __init__(self, host):
         self.host = host
         self.executive = host.executive
         self.fs = host.filesystem
         self.finder = WebKitFinder(self.fs)
         self.verbose = False
         self.allow_local_commits = False
         self.keep_w3c_repos_around = False
 
     def main(self, argv=None):
         self.parse_args(argv)
 
         self.cd('')
         if not self.checkout_is_okay():
             return 1
 
         self.print_('## noting the current Chromium commitish')
         chromium_commitish = self.run(['git', 'show-ref', 'HEAD'])[1].split()[0]
 
         if self.target == 'wpt':
-            import_commitish = self.update('web-platform-tests',
-                                           'https://chromium.googlesource.com/external/w3c/web-platform-tests.git')
+            import_commitish = self.update(
+                WPT_DEST_NAME,
+                'https://chromium.googlesource.com/external/w3c/web-platform-tests.git')
 
             for resource in ['testharnessreport.js', 'vendor-prefix.js']:
                 source = self.path_from_webkit_base('LayoutTests', 'resources', resource)
-                destination = self.path_from_webkit_base('LayoutTests', 'imported', 'web-platform-tests', 'resources', resource)
+                destination = self.path_from_webkit_base('LayoutTests', 'imported', WPT_DEST_NAME, 'resources', resource)
                 self.copyfile(source, destination)
                 self.run(['git', 'add', destination])
 
         elif self.target == 'css':
-            import_commitish = self.update('csswg-test',
-                                           'https://chromium.googlesource.com/external/w3c/csswg-test.git')
+            import_commitish = self.update(
+                CSS_DEST_NAME,
+                'https://chromium.googlesource.com/external/w3c/csswg-test.git')
         else:
             raise AssertionError("Unsupported target %s" % self.target)
 
         self.commit_changes_if_needed(chromium_commitish, import_commitish)
 
         return 0
 
     def parse_args(self, argv):
         parser = argparse.ArgumentParser()
         parser.description = __doc__
@@ skipping 15 matching lines @@
     def checkout_is_okay(self):
         if self.run(['git', 'diff', '--quiet', 'HEAD'], exit_on_failure=False)[0]:
             self.print_('## checkout is dirty, aborting')
             return False
 
         local_commits = self.run(['git', 'log', '--oneline', 'origin/master..HEAD'])[1]
         if local_commits and not self.allow_local_commits:
             self.print_('## checkout has local commits, aborting')
             return False
 
-        if self.fs.exists(self.path_from_webkit_base('web-platform-tests')):
+        if self.fs.exists(self.path_from_webkit_base(WPT_DEST_NAME)):
             self.print_('## web-platform-tests repo exists, aborting')
             return False
 
-        if self.fs.exists(self.path_from_webkit_base('csswg-test')):
+        if self.fs.exists(self.path_from_webkit_base(CSS_DEST_NAME)):
             self.print_('## csswg-test repo exists, aborting')
             return False
 
         return True
 
-    def update(self, repo, url):
-        self.print_('## cloning %s' % repo)
+    def update(self, dest, url):
+        """Updates an imported repository.
+
+        Args:
+            dest: The destination directory name.
+            url: URL of the git repository.
+
+        Returns:
+            A string for the commit description "<destination>@<commitish>".
+        """
+        self.print_('## cloning %s into %s' % (url, dest))
         self.cd('')
-        self.run(['git', 'clone', url])
-        self.cd(re.compile('.*/([^/]+)\.git').match(url).group(1))
+        self.run(['git', 'clone', url, dest])
+
+        self.cd(dest)
         self.run(['git', 'submodule', 'update', '--init', '--recursive'])
 
         self.print_('## noting the revision we are importing')
         master_commitish = self.run(['git', 'show-ref', 'origin/master'])[1].split()[0]
 
-        self.print_('## cleaning out tests from LayoutTests/imported/%s' % repo)
-        dest_repo = self.path_from_webkit_base('LayoutTests', 'imported', repo)
+        self.print_('## cleaning out tests from LayoutTests/imported/%s' % dest)
+        dest_repo = self.path_from_webkit_base('LayoutTests', 'imported', dest)
         files_to_delete = self.fs.files_under(dest_repo, file_filter=self.is_not_baseline)
         for subpath in files_to_delete:
             self.remove('LayoutTests', 'imported', subpath)
 
         self.print_('## importing the tests')
-        src_repo = self.path_from_webkit_base(repo)
+        src_repo = self.path_from_webkit_base(dest)
         import_path = self.path_from_webkit_base('Tools', 'Scripts', 'import-w3c-tests')
         self.run([self.host.executable, import_path, '-d', 'imported', src_repo])
 
         self.cd('')
-        self.run(['git', 'add', '--all', 'LayoutTests/imported/%s' % repo])
+        self.run(['git', 'add', '--all', 'LayoutTests/imported/%s' % dest])
 
         self.print_('## deleting manual tests')
         files_to_delete = self.fs.files_under(dest_repo, file_filter=self.is_manual_test)
         for subpath in files_to_delete:
             self.remove('LayoutTests', 'imported', subpath)
 
         self.print_('## deleting any orphaned baselines')
         previous_baselines = self.fs.files_under(dest_repo, file_filter=self.is_baseline)
         for subpath in previous_baselines:
             full_path = self.fs.join(dest_repo, subpath)
             if self.fs.glob(full_path.replace('-expected.txt', '*')) == [full_path]:
                 self.fs.remove(full_path)
 
         if not self.keep_w3c_repos_around:
-            self.print_('## deleting %s repo' % repo)
+            self.print_('## deleting %s repo directory' % dest)
             self.cd('')
             self.rmtree(repo)
 
-        return '%s@%s' % (repo, master_commitish)
+        return '%s@%s' % (dest, master_commitish)
 
     def commit_changes_if_needed(self, chromium_commitish, import_commitish):
         if self.run(['git', 'diff', '--quiet', 'HEAD'], exit_on_failure=False)[0]:
             self.print_('## commiting changes')
             commit_msg = ('Import %s\n'
                           '\n'
                           'Using update-w3c-deps in Chromium %s.\n'
                           % (import_commitish, chromium_commitish))
             path_to_commit_msg = self.path_from_webkit_base('commit_msg')
             if self.verbose:
@@ skipping 55 matching lines @@
         dest = self.path_from_webkit_base(*comps)
         if self.verbose:
             self.print_('rm -fr %s' % dest)
         self.fs.rmtree(dest)
 
     def path_from_webkit_base(self, *comps):
         return self.finder.path_from_webkit_base(*comps)
 
     def print_(self, msg):
         self.host.print_(msg)