Minor cleanup to webcursors.

Minor cleanup to webcursors:
* Deleted unused field external_handle_.
* Initialized some fields that weren't in the copy constructor.
* Copied device_scale_factor_ in the copy constructor.
* Added myself to OWNERS for this package.
* Removed unnecessary FRIEND_TEST macro.

BUG=611487
Committed: https://crrev.com/d7429aa21a2591d18ee9a45cbb9a2d3976090335
Cr-Commit-Position: refs/heads/master@{#393598}

[Bret, 2016-05-12 23:56:34]

Description was changed from

==========
Minor cleanup to webcursors:
* Deleted an unused field.
* Initialized some fields that weren't in the copy constructor.
* Copied device_scale_factor_ in the copy constructor.
* Added myself to OWNERS for this package.

BUG=611487
==========

to

==========
Minor cleanup to webcursors:
* Deleted unused field external_handle_.
* Initialized some fields that weren't in the copy constructor.
* Copied device_scale_factor_ in the copy constructor.
* Added myself to OWNERS for this package.
* Removed unnecessary FRIEND_TEST macro.

BUG=611487
==========

[Bret, 2016-05-12 23:56:34]

bsep@chromium.org changed reviewers:
+ ananta@chromium.org, scottmg@chromium.org

[Bret, 2016-05-12 23:59:15]

bsep@chromium.org changed reviewers:
+ jam@chromium.org
- ananta@chromium.org

[Bret, 2016-05-13 00:00:04]

jam@: just need OWNERS stamp

[scottmg, 2016-05-13 00:27:21]

https://codereview.chromium.org/1975033002/diff/40001/content/common/cursors/...
File content/common/cursors/webcursor.cc (left):

https://codereview.chromium.org/1975033002/diff/40001/content/common/cursors/...
content/common/cursors/webcursor.cc:202: if (cursor_type ==
WebCursorInfo::TypeCustom)
Do we need to CHECK(cursor_type != WebCursorInfo::TypeCustom) here?

https://codereview.chromium.org/1975033002/diff/40001/content/common/cursors/...
File content/common/cursors/webcursor_unittest.cc (right):

https://codereview.chromium.org/1975033002/diff/40001/content/common/cursors/...
content/common/cursors/webcursor_unittest.cc:322: namespace {
\n after { (make opening and closing match)

[Bret, 2016-05-13 00:53:17]

https://codereview.chromium.org/1975033002/diff/40001/content/common/cursors/...
File content/common/cursors/webcursor.cc (left):

https://codereview.chromium.org/1975033002/diff/40001/content/common/cursors/...
content/common/cursors/webcursor.cc:202: if (cursor_type ==
WebCursorInfo::TypeCustom)
On 2016/05/13 00:27:21, scottmg wrote:
> Do we need to CHECK(cursor_type != WebCursorInfo::TypeCustom) here?

Ah nope, just forgot to delete this function.

https://codereview.chromium.org/1975033002/diff/40001/content/common/cursors/...
File content/common/cursors/webcursor_unittest.cc (right):

https://codereview.chromium.org/1975033002/diff/40001/content/common/cursors/...
content/common/cursors/webcursor_unittest.cc:322: namespace {
On 2016/05/13 00:27:21, scottmg wrote:
> \n after { (make opening and closing match)

Done.

[jam, 2016-05-13 01:12:55]

lgtm for files outside content/common/cursors/

https://codereview.chromium.org/1975033002/diff/60001/content/common/cursors/...
File content/common/cursors/OWNERS (right):

https://codereview.chromium.org/1975033002/diff/60001/content/common/cursors/...
content/common/cursors/OWNERS:1: ananta@chromium.org
since ananta is owner here already, please send this change to him for review
(i.e. specifically the files in this directory)

[Bret, 2016-05-13 01:29:38]

bsep@chromium.org changed reviewers:
+ ananta@chromium.org

[ananta, 2016-05-13 01:34:11]

lgtm

[Bret, 2016-05-13 01:34:54]

The CQ bit was checked by bsep@chromium.org

[commit-bot: I haz the power, 2016-05-13 01:35:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1975033002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1975033002/60001

[commit-bot: I haz the power, 2016-05-13 02:37:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-13 02:37:26]

Try jobs failed on following builders:
  win_clang on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Bret, 2016-05-13 17:48:44]

The CQ bit was checked by bsep@chromium.org

[Bret, 2016-05-13 17:48:44]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org,
ananta@chromium.org
Link to the patchset: https://codereview.chromium.org/1975033002/#ps80001
(title: "delete another function")

[commit-bot: I haz the power, 2016-05-13 17:49:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1975033002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1975033002/80001

[commit-bot: I haz the power, 2016-05-13 19:09:53]

Description was changed from

==========
Minor cleanup to webcursors:
* Deleted unused field external_handle_.
* Initialized some fields that weren't in the copy constructor.
* Copied device_scale_factor_ in the copy constructor.
* Added myself to OWNERS for this package.
* Removed unnecessary FRIEND_TEST macro.

BUG=611487
==========

to

==========
Minor cleanup to webcursors:
* Deleted unused field external_handle_.
* Initialized some fields that weren't in the copy constructor.
* Copied device_scale_factor_ in the copy constructor.
* Added myself to OWNERS for this package.
* Removed unnecessary FRIEND_TEST macro.

BUG=611487
==========

[commit-bot: I haz the power, 2016-05-13 19:09:55]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-05-13 19:11:39]

Description was changed from

==========
Minor cleanup to webcursors:
* Deleted unused field external_handle_.
* Initialized some fields that weren't in the copy constructor.
* Copied device_scale_factor_ in the copy constructor.
* Added myself to OWNERS for this package.
* Removed unnecessary FRIEND_TEST macro.

BUG=611487
==========

to

==========
Minor cleanup to webcursors:
* Deleted unused field external_handle_.
* Initialized some fields that weren't in the copy constructor.
* Copied device_scale_factor_ in the copy constructor.
* Added myself to OWNERS for this package.
* Removed unnecessary FRIEND_TEST macro.

BUG=611487

Committed: https://crrev.com/d7429aa21a2591d18ee9a45cbb9a2d3976090335
Cr-Commit-Position: refs/heads/master@{#393598}
==========

[commit-bot: I haz the power, 2016-05-13 19:11:40]

Patchset 5 (id:??) landed as
https://crrev.com/d7429aa21a2591d18ee9a45cbb9a2d3976090335
Cr-Commit-Position: refs/heads/master@{#393598}