Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 1975013002: Disable various MediaSourcePlayerTests on unsupported devices (Closed)

Created:
4 years, 7 months ago by kraush
Modified:
4 years, 7 months ago
Reviewers:
qinmin
CC:
chromium-reviews, feature-media-reviews_chromium.org, avayvod+watch_chromium.org, mlamouri+watch-media_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable various MediaSourcePlayerTests on unsupported devices Most MediaSourcePlayerTests require vp8 support to work. Since VP8 was recently disabled on all MediaTek chipsets, this change disables them on unsupported devices. It also fixes media_codec_util's IsVp8/9DecoderAvailable by using the accurate name for the respective mimes. BUG=611578 Committed: https://crrev.com/8a541deee22a02150efc1014167520c835be7e5c Cr-Commit-Position: refs/heads/master@{#393422}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -33 lines) Patch
M media/base/android/media_codec_util.h View 1 chunk +9 lines, -0 lines 0 comments Download
M media/base/android/media_source_player_unittest.cc View 33 chunks +66 lines, -33 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kraush
Hi, As discussed by email, can you take a look at this test suppression for ...
4 years, 7 months ago (2016-05-12 22:50:25 UTC) #2
qinmin
lgtm
4 years, 7 months ago (2016-05-12 23:25:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1975013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1975013002/1
4 years, 7 months ago (2016-05-13 00:41:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-13 01:40:54 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 01:43:39 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8a541deee22a02150efc1014167520c835be7e5c
Cr-Commit-Position: refs/heads/master@{#393422}

Powered by Google App Engine
This is Rietveld 408576698