chrome/browser/ui/webui/settings/about_handler.cc - Issue 1975003002: MD Settings: About page, implementing detailed build info.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/settings/about_handler.cc

Issue 1975003002: MD Settings: About page, implementing detailed build info. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing comments. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/settings_resources.grd ('k') | chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/settings/about_handler.cc

diff --git a/chrome/browser/ui/webui/settings/about_handler.cc b/chrome/browser/ui/webui/settings/about_handler.cc

index 26b4a2d4f21a700a9c8d89d8aa113cc1b10beeb8..2324cb5fcab7d1515d98aa83c02d54769fab47e6 100644

--- a/chrome/browser/ui/webui/settings/about_handler.cc

+++ b/chrome/browser/ui/webui/settings/about_handler.cc

@@ -296,6 +296,14 @@ AboutHandler* AboutHandler::Create(content::WebUIDataSource* html_source,

base::Time build_time = base::SysInfo::GetLsbReleaseTime();

base::string16 build_date = base::TimeFormatFriendlyDate(build_time);

html_source->AddString("aboutBuildDate", build_date);

+ base::CommandLine::StringType command_line =

+ base::CommandLine::ForCurrentProcess()->GetCommandLineString();

+ html_source->AddString("aboutCommandLine", command_line);

+ html_source->AddString("aboutUserAgent", GetUserAgent());

+ html_source->AddString("aboutJsEngineVersion", v8::V8::GetVersion());

+ html_source->AddString("aboutBlinkVersion", content::GetWebKitVersion());

#endif

return new AboutHandler();