Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: chrome/browser/resources/settings/about_page/about_page_browser_proxy.js

Issue 1975003002: MD Settings: About page, implementing detailed build info. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix tests. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/about_page/about_page_browser_proxy.js
diff --git a/chrome/browser/resources/settings/about_page/about_page_browser_proxy.js b/chrome/browser/resources/settings/about_page/about_page_browser_proxy.js
index a9d76c80cef00f6cb647a66f96283e1c15f25a20..ace48ae3ad22ba7d19cad68e7ff4d31687ebd2ff 100644
--- a/chrome/browser/resources/settings/about_page/about_page_browser_proxy.js
+++ b/chrome/browser/resources/settings/about_page/about_page_browser_proxy.js
@@ -24,19 +24,19 @@ var RegulatoryInfo;
* }}
*/
var VersionInfo;
+
+/**
+ * Enumeration of all possible browser channels.
+ * @enum {string}
+ */
+var BrowserChannel = {
+ BETA: 'beta-channel',
+ DEV: 'dev-channel',
+ STABLE: 'stable-channel',
+};
</if>
cr.define('settings', function() {
- /**
- * Enumeration of all possible browser channels.
- * @enum {string}
- */
- var BrowserChannel = {
- BETA: 'beta-channel',
- DEV: 'dev-channel',
- STABLE: 'stable-channel',
- };
-
/** @interface */
function AboutPageBrowserProxy() {}
@@ -74,10 +74,10 @@ cr.define('settings', function() {
*/
setChannel: function(channel, isPowerwashAllowed) {},
- /** @return {!Promise<string>} */
+ /** @return {!Promise<!BrowserChannel>} */
getCurrentChannel: function() {},
- /** @return {!Promise<string>} */
+ /** @return {!Promise<!BrowserChannel>} */
getTargetChannel: function() {},
/** @return {!Promise<!VersionInfo>} */

Powered by Google App Engine
This is Rietveld 408576698