Chromium Code Reviews| Index: src/gpu/vk/GrVkTextureRenderTarget.h |
| diff --git a/src/gpu/vk/GrVkTextureRenderTarget.h b/src/gpu/vk/GrVkTextureRenderTarget.h |
| index e888397cddbbaa036fceb2471e48ec3b9b1b8e73..320cb371c245eb195e0fd0ada3ba40193e4b13bc 100644 |
| --- a/src/gpu/vk/GrVkTextureRenderTarget.h |
| +++ b/src/gpu/vk/GrVkTextureRenderTarget.h |
| @@ -20,7 +20,7 @@ |
| #endif |
| class GrVkImageView; |
| -struct GrVkTextureInfo; |
| +struct GrVkImageInfo; |
| class GrVkTextureRenderTarget: public GrVkTexture, public GrVkRenderTarget { |
| public: |
| @@ -31,8 +31,7 @@ public: |
| static GrVkTextureRenderTarget* CreateWrappedTextureRenderTarget(GrVkGpu*, |
| const GrSurfaceDesc&, |
| GrWrapOwnership, |
| - VkFormat, |
| - const GrVkTextureInfo*); |
| + const GrVkImageInfo*); |
| protected: |
| void onAbandon() override { |
| @@ -49,67 +48,66 @@ private: |
| GrVkTextureRenderTarget(GrVkGpu* gpu, |
| SkBudgeted budgeted, |
| const GrSurfaceDesc& desc, |
| - const GrVkImage::Resource* imageResource, |
| + const GrVkImageInfo& info, |
| const GrVkImageView* texView, |
| - const GrVkImage::Resource* msaaResource, |
| + const GrVkImageInfo& msaaInfo, |
| const GrVkImageView* colorAttachmentView, |
| const GrVkImageView* resolveAttachmentView) |
| : GrSurface(gpu, desc) |
| - , GrVkImage(imageResource) |
| - , GrVkTexture(gpu, desc, imageResource, texView) |
| - , GrVkRenderTarget(gpu, desc, imageResource, msaaResource, colorAttachmentView, |
| - resolveAttachmentView) { |
| + , GrVkImage(info, false) |
| + , GrVkTexture(gpu, desc, info, texView, false) |
| + , GrVkRenderTarget(gpu, desc, info, msaaInfo, colorAttachmentView, |
| + resolveAttachmentView, false) { |
| this->registerWithCache(budgeted); |
| } |
| GrVkTextureRenderTarget(GrVkGpu* gpu, |
| SkBudgeted budgeted, |
| const GrSurfaceDesc& desc, |
| - const GrVkImage::Resource* imageResource, |
| + const GrVkImageInfo& info, |
| const GrVkImageView* texView, |
| const GrVkImageView* colorAttachmentView) |
| : GrSurface(gpu, desc) |
| - , GrVkImage(imageResource) |
| - , GrVkTexture(gpu, desc, imageResource, texView) |
| - , GrVkRenderTarget(gpu, desc, imageResource, colorAttachmentView) { |
| + , GrVkImage(info, false) |
| + , GrVkTexture(gpu, desc, info, texView, false) |
| + , GrVkRenderTarget(gpu, desc, info, colorAttachmentView, false) { |
| this->registerWithCache(budgeted); |
| } |
| - enum Wrapped { kWrapped }; |
| GrVkTextureRenderTarget(GrVkGpu* gpu, |
| - Wrapped, |
| const GrSurfaceDesc& desc, |
| - const GrVkImage::Resource* imageResource, |
| + const GrVkImageInfo& info, |
| const GrVkImageView* texView, |
| - const GrVkImage::Resource* msaaResource, |
| + const GrVkImageInfo& msaaInfo, |
| const GrVkImageView* colorAttachmentView, |
| - const GrVkImageView* resolveAttachmentView) |
| + const GrVkImageView* resolveAttachmentView, |
| + bool isBorrowed) |
| : GrSurface(gpu, desc) |
| - , GrVkImage(imageResource) |
| - , GrVkTexture(gpu, desc, imageResource, texView) |
| - , GrVkRenderTarget(gpu, desc, imageResource, msaaResource, colorAttachmentView, |
| - resolveAttachmentView) { |
| + , GrVkImage(info, isBorrowed) |
| + , GrVkTexture(gpu, desc, info, texView, isBorrowed) |
| + , GrVkRenderTarget(gpu, desc, info, msaaInfo, colorAttachmentView, |
| + resolveAttachmentView, isBorrowed) { |
| this->registerWithCacheWrapped(); |
| } |
| GrVkTextureRenderTarget(GrVkGpu* gpu, |
| - Wrapped, |
| const GrSurfaceDesc& desc, |
| - const GrVkImage::Resource* imageResource, |
| + const GrVkImageInfo& info, |
| const GrVkImageView* texView, |
| - const GrVkImageView* colorAttachmentView) |
| + const GrVkImageView* colorAttachmentView, |
| + bool isBorrowed) |
| : GrSurface(gpu, desc) |
| - , GrVkImage(imageResource) |
| - , GrVkTexture(gpu, desc, imageResource, texView) |
| - , GrVkRenderTarget(gpu, desc, imageResource, colorAttachmentView) { |
| + , GrVkImage(info, isBorrowed) |
| + , GrVkTexture(gpu, desc, info, texView, isBorrowed) |
| + , GrVkRenderTarget(gpu, desc, info, colorAttachmentView, isBorrowed) { |
| this->registerWithCacheWrapped(); |
| } |
| - template <typename ResourceType> |
| static GrVkTextureRenderTarget* Create(GrVkGpu*, |
| - ResourceType, |
| const GrSurfaceDesc&, |
| - VkFormat, |
| - const GrVkImage::Resource* imageResource); |
| + const GrVkImageInfo&, |
| + SkBudgeted budgeted, |
| + bool isWrapped, |
|
jvanverth1
2016/05/13 16:14:40
Here's a case where using an enum for isBorrowed w
egdaniel
2016/05/13 18:00:05
Done.
|
| + bool isBorrowed); |
| // GrGLRenderTarget accounts for the texture's memory and any MSAA renderbuffer's memory. |
| size_t onGpuMemorySize() const override { |