Refactor Vulkan image, texture, RTs so that create and getter handles match.

src/gpu/vk/GrVkImage.h

 /*
  * Copyright 2015 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef GrVkImage_DEFINED
 #define GrVkImage_DEFINED
 
 #include "GrVkResource.h"
 
 #include "GrTypesPriv.h"
 #include "SkTypes.h"
 
 #include "vk/GrVkDefines.h"
+#include "vk/GrVkTypes.h"
 
 class GrVkGpu;
 
 class GrVkImage : SkNoncopyable {
+private:
+    class Resource;
+
 public:
-    // unlike GrVkBuffer, this needs to be public so GrVkStencilAttachment can use it
-    class Resource : public GrVkResource {
-    public:
-        enum Flags {
-            kNo_Flags = 0,
-            kLinearTiling_Flag = 0x01,
-            kBorrowed_Flag = 0x02
-        };
+    GrVkImage(const GrVkImageInfo& info, bool isBorrowed) : fInfo(info), fIsBorrowed(isBorrowed) {

[jvanverth1, 2016/05/13 16:14:40]

Suggestion: make isBorrowed an enum rather than a bool, so it's clear what false
and true mean.

[egdaniel, 2016/05/13 18:00:05]

Done.

+        if (isBorrowed) {
+            fResource = new BorrowedResource(info.fImage, info.fAlloc);
+        } else {
+            fResource = new Resource(info.fImage, info.fAlloc);
+        }
+    }
+    virtual ~GrVkImage();
 
-        VkImage                  fImage;
-        VkDeviceMemory           fAlloc;
-        VkFormat                 fFormat;
-        uint32_t                 fLevelCount;
-        uint32_t                 fFlags;
-
-        Resource()
-            : INHERITED()
-            , fImage(VK_NULL_HANDLE)
-            , fAlloc(VK_NULL_HANDLE)
-            , fFormat(VK_FORMAT_UNDEFINED)
-            , fLevelCount(0)
-            , fFlags(kNo_Flags) {}
-
-        Resource(VkImage image, VkDeviceMemory alloc, VkFormat format, uint32_t levelCount,
-                 uint32_t flags)
-            : fImage(image), fAlloc(alloc), fFormat(format), fLevelCount(levelCount)
-            , fFlags(flags) {}
-
-        ~Resource() override {}
-
-    private:
-        void freeGPUData(const GrVkGpu* gpu) const override;
-
-        typedef GrVkResource INHERITED;
-    };
-
-    // for wrapped textures
-    class BorrowedResource : public Resource {
-    public:
-        BorrowedResource(VkImage image, VkDeviceMemory alloc, VkFormat format, uint32_t levelCount,
-                         uint32_t flags)
-            : Resource(image, alloc, format, levelCount, (flags | kBorrowed_Flag)) {
-        }
-    private:
-        void freeGPUData(const GrVkGpu* gpu) const override;
-    };
-
-    GrVkImage(const Resource* imageResource) : fResource(imageResource) {
-        if (imageResource->fFlags & Resource::kLinearTiling_Flag) {
-            fCurrentLayout = VK_IMAGE_LAYOUT_PREINITIALIZED;
-        } else {
-            fCurrentLayout = VK_IMAGE_LAYOUT_UNDEFINED;
-        }
-        imageResource->ref();
+    VkImage image() const { return fInfo.fImage; }
+    VkDeviceMemory memory() const { return fInfo.fAlloc; }
+    VkFormat imageFormat() const { return fInfo.fFormat; }
+    const Resource* resource() const { return fResource; }
+    bool isLinearTiled() const {
+        return SkToBool(VK_IMAGE_TILING_LINEAR == fInfo.fImageTiling);
     }
 
-    virtual ~GrVkImage();
-
-    VkImage textureImage() const { return fResource->fImage; }
-    VkDeviceMemory textureMemory() const { return fResource->fAlloc; }
-    const Resource* resource() const { return fResource; }
-    bool isLinearTiled() const {
-        return SkToBool(fResource->fFlags & Resource::kLinearTiling_Flag);
-    }
-
-    VkImageLayout currentLayout() const { return fCurrentLayout; }
+    VkImageLayout currentLayout() const { return fInfo.fImageLayout; }
 
     void setImageLayout(const GrVkGpu* gpu,
                         VkImageLayout newLayout,
                         VkAccessFlags dstAccessMask,
                         VkPipelineStageFlags dstStageMask,
                         bool byRegion);
 
     struct ImageDesc {
         VkImageType         fImageType;
         VkFormat            fFormat;
@@ skipping 10 matching lines @@
             , fFormat(VK_FORMAT_UNDEFINED)
             , fWidth(0)
             , fHeight(0)
             , fLevels(1)
             , fSamples(1)
             , fImageTiling(VK_IMAGE_TILING_OPTIMAL)
             , fUsageFlags(0)
             , fMemProps(VK_MEMORY_PROPERTY_DEVICE_LOCAL_BIT) {}
     };
 
-    static const Resource* CreateResource(const GrVkGpu* gpu, const ImageDesc& imageDesc);
+    static bool GetImageInfo(const GrVkGpu* gpu, const ImageDesc& imageDesc, GrVkImageInfo*);
 
 protected:
-
     void releaseImage(const GrVkGpu* gpu);
     void abandonImage();
 
+    void setNewResource(VkImage image, VkDeviceMemory alloc);
+
+    GrVkImageInfo   fInfo;
+    bool            fIsBorrowed;
+
+private:
+    // unlike GrVkBuffer, this needs to be public so GrVkStencilAttachment can use it
+    class Resource : public GrVkResource {
+    public:
+        Resource()
+            : INHERITED()
+            , fImage(VK_NULL_HANDLE)
+            , fAlloc(VK_NULL_HANDLE) {
+        }
+
+        Resource(VkImage image, VkDeviceMemory alloc) : fImage(image), fAlloc(alloc) {}
+
+        ~Resource() override {}
+
+    private:
+        void freeGPUData(const GrVkGpu* gpu) const override;
+
+        VkImage                  fImage;
+        VkDeviceMemory           fAlloc;
+
+        typedef GrVkResource INHERITED;
+    };
+
+    // for wrapped textures
+    class BorrowedResource : public Resource {
+    public:
+        BorrowedResource(VkImage image, VkDeviceMemory alloc) : Resource(image, alloc) {
+        }
+    private:
+        void freeGPUData(const GrVkGpu* gpu) const override;
+    };
+
     const Resource* fResource;
 
-    VkImageLayout   fCurrentLayout;
+    friend class GrVkRenderTarget;
 };
 
 #endif