Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1510)

Issue 1974963002: Output divs using descendant nodes. (Closed)

Created:
4 years, 7 months ago by David Tseng
Modified:
4 years, 7 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Output divs using descendant nodes. Some sites contain complex divs which they focus in order to force output of rich content. Enclosed is an example similar to content found on Google Plus. BUG=605396 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/a6d987106258a552e3da0cd1c7f5ac75151a30a2 Cr-Commit-Position: refs/heads/master@{#393654}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/live_regions_test.extjs View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
David Tseng
4 years, 7 months ago (2016-05-12 19:58:00 UTC) #4
dmazzoni
lgtm
4 years, 7 months ago (2016-05-13 20:05:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1974963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1974963002/1
4 years, 7 months ago (2016-05-13 20:48:03 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-13 22:01:13 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 22:02:15 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a6d987106258a552e3da0cd1c7f5ac75151a30a2
Cr-Commit-Position: refs/heads/master@{#393654}

Powered by Google App Engine
This is Rietveld 408576698