Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issue 1974933002: [wasm] Remove the use of the "external" bit on OldFunctions section. (Closed)

Created:
4 years, 7 months ago by titzer
Modified:
4 years, 7 months ago
Reviewers:
bradnelson, aseemgarg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Remove the use of the "external" bit on OldFunctions section. This is a first step to removing the support for the OldFunctions section altogether, which will greatly simplify the encoder and remove the need to do local variable remapping in asm->wasm. R=bradnelson@chromium.org,aseemgarg@chromium.org BUG= Committed: https://crrev.com/7cd1a7f768f22d91863c2168cef5ea12dab8752b Cr-Commit-Position: refs/heads/master@{#36228}

Patch Set 1 #

Patch Set 2 : Remove unused variable. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -192 lines) Patch
M src/compiler/wasm-compiler.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/wasm/asm-wasm-builder.cc View 1 6 chunks +19 lines, -22 lines 0 comments Download
M src/wasm/encoder.h View 8 chunks +14 lines, -9 lines 0 comments Download
M src/wasm/encoder.cc View 14 chunks +58 lines, -32 lines 0 comments Download
M src/wasm/module-decoder.cc View 6 chunks +7 lines, -19 lines 0 comments Download
M src/wasm/wasm-module.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/wasm/wasm-module.cc View 1 4 chunks +28 lines, -49 lines 0 comments Download
M test/cctest/wasm/test-wasm-function-name-table.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/wasm/wasm-run-utils.h View 1 chunk +1 line, -2 lines 0 comments Download
M test/unittests/wasm/ast-decoder-unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M test/unittests/wasm/module-decoder-unittest.cc View 17 chunks +17 lines, -53 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
titzer
4 years, 7 months ago (2016-05-12 18:24:16 UTC) #1
bradnelson
lgtm
4 years, 7 months ago (2016-05-12 18:33:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1974933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1974933002/1
4 years, 7 months ago (2016-05-12 18:33:57 UTC) #4
bradnelson
You have a gcc warning.
4 years, 7 months ago (2016-05-12 18:35:05 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/builds/16101)
4 years, 7 months ago (2016-05-12 18:46:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1974933002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1974933002/20001
4 years, 7 months ago (2016-05-13 08:35:11 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-13 08:44:36 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 08:46:52 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7cd1a7f768f22d91863c2168cef5ea12dab8752b
Cr-Commit-Position: refs/heads/master@{#36228}

Powered by Google App Engine
This is Rietveld 408576698