Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1575)

Unified Diff: runtime/lib/mirrors_impl.dart

Issue 19749008: Fix regression in TypedefMirror.owner introduced when making ClassMirror.owner lazy. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/lib/mirrors/mirrors_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/mirrors_impl.dart
===================================================================
--- runtime/lib/mirrors_impl.dart (revision 25237)
+++ runtime/lib/mirrors_impl.dart (working copy)
@@ -725,6 +725,9 @@
Symbol _qualifiedName = null;
Symbol get qualifiedName {
+ if (_owner == null) {
+ _owner = _LocalClassMirrorImpl._library(_reflectee);
+ }
siva 2013/07/19 21:06:07 Why not put this code in 'get owner' so that we ar
rmacnak 2013/07/19 21:11:39 Yikes, mistake in moving from one checkout to anot
if (_qualifiedName == null) {
_qualifiedName = _computeQualifiedName(owner, simpleName);
}
« no previous file with comments | « no previous file | tests/lib/mirrors/mirrors_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698