Processing timefences from the server.

chrome/browser/resources/google_now/background.js

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /**
  * @fileoverview The event page for Google Now for Chrome implementation.
  * The Google Now event page gets Google Now cards from the server and shows
  * them as Chrome notifications.
@@ skipping 97 matching lines @@
     // send dismissals is scheduled.
     return true;
   }
 
   return false;
 }
 
 var tasks = buildTaskManager(areTasksConflicting);
 
 // Add error processing to API calls.
+tasks.instrumentApiFunction(chrome.alarms, 'getAll', 0);

[rgustafson, 2013/07/19 23:37:12]

Where is alarms.getAll used?

[vadimt, 2013/07/22 19:22:52]

Done.

 tasks.instrumentApiFunction(chrome.identity, 'getAuthToken', 1);
 tasks.instrumentApiFunction(chrome.identity, 'removeCachedAuthToken', 1);
 tasks.instrumentApiFunction(chrome.location.onLocationUpdate, 'addListener', 0);
 tasks.instrumentApiFunction(chrome.notifications, 'create', 2);
 tasks.instrumentApiFunction(chrome.notifications, 'update', 2);
 tasks.instrumentApiFunction(chrome.notifications, 'getAll', 0);
 tasks.instrumentApiFunction(
     chrome.notifications.onButtonClicked, 'addListener', 0);
 tasks.instrumentApiFunction(chrome.notifications.onClicked, 'addListener', 0);
 tasks.instrumentApiFunction(chrome.notifications.onClosed, 'addListener', 0);
 tasks.instrumentApiFunction(chrome.runtime.onInstalled, 'addListener', 0);
 tasks.instrumentApiFunction(chrome.runtime.onStartup, 'addListener', 0);
 tasks.instrumentApiFunction(chrome.tabs, 'create', 1);
 tasks.instrumentApiFunction(storage, 'get', 1);
 
 var updateCardsAttempts = buildAttemptManager(
     'cards-update',
     requestLocation,
     INITIAL_POLLING_PERIOD_SECONDS,
     MAXIMUM_POLLING_PERIOD_SECONDS);
 var dismissalAttempts = buildAttemptManager(
     'dismiss',
     retryPendingDismissals,
     INITIAL_RETRY_DISMISS_PERIOD_SECONDS,
     MAXIMUM_RETRY_DISMISS_PERIOD_SECONDS);
+var cardSet = buildCardManager();
 
 /**
  * Diagnostic event identifier.
  * @enum {number}
  */
 var DiagnosticEvent = {
   REQUEST_FOR_CARDS_TOTAL: 0,
   REQUEST_FOR_CARDS_SUCCESS: 1,
   CARDS_PARSE_SUCCESS: 2,
   DISMISS_REQUEST_TOTAL: 3,
@@ skipping 57 matching lines @@
       } else {
         originalOnLoadEnd(event);
       }
     });
 
     callbackBoolean(true);
   });
 }
 
 /**
- * Shows a notification and remembers information associated with it.
- * @param {Object} card Google Now card represented as a set of parameters for
- *     showing a Chrome notification.
- * @param {Object} notificationsData Map from notification id to the data
- *     associated with a notification.
- * @param {number=} opt_previousVersion The version of the shown card with this
- *     id, if it exists, undefined otherwise.
- */
-function showNotification(card, notificationsData, opt_previousVersion) {
-  console.log('showNotification ' + JSON.stringify(card) + ' ' +
-             opt_previousVersion);
-
-  if (typeof card.version != 'number') {
-    console.error('card.version is not a number');
-    // Fix card version.
-    card.version = opt_previousVersion !== undefined ? opt_previousVersion : 0;
-  }
-
-  if (opt_previousVersion !== card.version) {
-    try {
-      // Delete a notification with the specified id if it already exists, and
-      // then create a notification.
-      chrome.notifications.create(
-          card.notificationId,
-          card.notification,
-          function(notificationId) {
-            if (!notificationId || chrome.runtime.lastError) {
-              var errorMessage =
-                  chrome.runtime.lastError && chrome.runtime.lastError.message;
-              console.error('notifications.create: ID=' + notificationId +
-                            ', ERROR=' + errorMessage);
-            }
-          });
-    } catch (error) {
-      console.error('Error in notifications.create: ' + error);
-    }
-  } else {
-    try {
-      // Update existing notification.
-      chrome.notifications.update(
-          card.notificationId,
-          card.notification,
-          function(wasUpdated) {
-            if (!wasUpdated || chrome.runtime.lastError) {
-              var errorMessage =
-                  chrome.runtime.lastError && chrome.runtime.lastError.message;
-              console.error('notifications.update: UPDATED=' + wasUpdated +
-                            ', ERROR=' + errorMessage);
-            }
-          });
-    } catch (error) {
-      console.error('Error in notifications.update: ' + error);
-    }
-  }
-
-  notificationsData[card.notificationId] = {
-    actionUrls: card.actionUrls,
-    version: card.version
-  };
-}
-
-/**
  * Parses JSON response from the notification server, show notifications and
  * schedule next update.
  * @param {string} response Server response.
  * @param {function()} callback Completion callback.
  */
 function parseAndShowNotificationCards(response, callback) {
   console.log('parseAndShowNotificationCards ' + response);
   try {
     var parsedResponse = JSON.parse(response);
   } catch (error) {
     console.error('parseAndShowNotificationCards parse error: ' + error);
     callback();
     return;
   }
 
   var cards = parsedResponse.cards;
 
   if (!(cards instanceof Array)) {
     callback();
     return;
   }
 
   if (typeof parsedResponse.expiration_timestamp_seconds != 'number') {

[rgustafson, 2013/07/22 17:48:07]

Can we change expiration_timestamp_seconds to next_poll_seconds? Right now it is
being sent as both by the server. The former doesn't make any sense since its
not a timestamp.

[vadimt, 2013/07/22 19:22:52]

Done.

     callback();
     return;
   }
 
   tasks.debugSetStepName('parseAndShowNotificationCards-storage-get');
   storage.get(['notificationsData', 'recentDismissals'], function(items) {
     console.log('parseAndShowNotificationCards-get ' + JSON.stringify(items));
     items.notificationsData = items.notificationsData || {};
     items.recentDismissals = items.recentDismissals || {};
 
     tasks.debugSetStepName(
         'parseAndShowNotificationCards-notifications-getAll');
     chrome.notifications.getAll(function(notifications) {
       console.log('parseAndShowNotificationCards-getAll ' +
           JSON.stringify(notifications));
-      // TODO(vadimt): Figure out what to do when notifications are disabled for
-      // our extension.
-      notifications = notifications || {};
+    // TODO(vadimt): Figure out what to do when notifications are disabled for

[rgustafson, 2013/07/19 23:37:12]

Why was this un-tabbed? It should be on the level on console.log

[vadimt, 2013/07/22 19:22:52]

Done. I probably need to see my doctor.

+    // our extension.
+    notifications = notifications || {};
 
       // Build a set of non-expired recent dismissals. It will be used for
       // client-side filtering of cards.
       var updatedRecentDismissals = {};
       var currentTimeMs = Date.now();
       for (var notificationId in items.recentDismissals) {
         if (currentTimeMs - items.recentDismissals[notificationId] <
             DISMISS_RETENTION_TIME_MS) {
           updatedRecentDismissals[notificationId] =
               items.recentDismissals[notificationId];
@@ skipping 11 matching lines @@
           updatedNotifications[notificationId] = true;
         }
       }
 
       // Delete notifications that didn't receive an update.
       for (var notificationId in notifications) {
         console.log('parseAndShowNotificationCards-delete-check ' +
                     notificationId);
         if (!(notificationId in updatedNotifications)) {
           console.log('parseAndShowNotificationCards-delete ' + notificationId);
-          chrome.notifications.clear(
-              notificationId,
-              function() {});
+          cardSet.clear(notificationId);
         }
       }
 
       recordEvent(DiagnosticEvent.CARDS_PARSE_SUCCESS);
 
       // Create/update notifications and store their new properties.
       var newNotificationsData = {};
       for (var i = 0; i < cards.length; ++i) {
         var card = cards[i];
         if (!(card.notificationId in updatedRecentDismissals)) {
           var notificationData = items.notificationsData[card.notificationId];
           var previousVersion = notifications[card.notificationId] &&
                                 notificationData &&
-                                notificationData.previousVersion;
-          showNotification(card, newNotificationsData, previousVersion);
+                                notificationData.cardCreateInfo &&
+                                notificationData.cardCreateInfo.version;
+          newNotificationsData[card.notificationId] =
+              cardSet.update(card, previousVersion);
         }
       }
 
       updateCardsAttempts.start(parsedResponse.expiration_timestamp_seconds);

[rgustafson, 2013/07/22 17:48:07]

expiration_timestamp_seconds to next_poll_seconds

[vadimt, 2013/07/22 19:22:52]

Done.

 
       storage.set({
         notificationsData: newNotificationsData,
         recentDismissals: updatedRecentDismissals
       });
       callback();
     });
   });
 }
 
@@ skipping 248 matching lines @@
   }
 
   // At this point we are guaranteed that the notification is a now card.
   chrome.metricsPrivate.recordUserAction('GoogleNow.Dismissed');
 
   tasks.add(DISMISS_CARD_TASK_NAME, function(callback) {
     dismissalAttempts.start();
 
     // Deleting the notification in case it was re-added while this task was
     // scheduled, waiting for execution.
-    chrome.notifications.clear(
-        notificationId,
-        function() {});
+    cardSet.clear(notificationId);
 
     tasks.debugSetStepName('onNotificationClosed-get-pendingDismissals');
     storage.get('pendingDismissals', function(items) {
       items.pendingDismissals = items.pendingDismissals || [];
 
       var dismissal = {
         notificationId: notificationId,
         time: Date.now()
       };
       items.pendingDismissals.push(dismissal);
@@ skipping 101 matching lines @@
 
 chrome.location.onLocationUpdate.addListener(function(position) {
   recordEvent(DiagnosticEvent.LOCATION_UPDATE);
   updateNotificationsCards(position);
 });
 
 chrome.omnibox.onInputEntered.addListener(function(text) {
   localStorage['server_url'] = NOTIFICATION_CARDS_URL = text;
   initialize();
 });