src/arm/ic-arm.cc - Issue 19749004: With >= 64 non-string instance types, I removed an optimization

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/ic-arm.cc

Issue 19749004: With >= 64 non-string instance types, I removed an optimization (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Review comments Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm/ic-arm.cc

diff --git a/src/arm/ic-arm.cc b/src/arm/ic-arm.cc

index f5a1fc3fb4f41a2aac673900d199bddc6af9c21d..ee28d2819857431fc3cb19c8d658efb5653b39a3 100644

--- a/src/arm/ic-arm.cc

+++ b/src/arm/ic-arm.cc

@@ -325,9 +325,9 @@ static void GenerateKeyNameCheck(MacroAssembler* masm,

// bit test is enough.

// map: key map

__ ldrb(hash, FieldMemOperand(map, Map::kInstanceTypeOffset));

- STATIC_ASSERT(kInternalizedTag != 0);

- __ tst(hash, Operand(kIsInternalizedMask));

- __ b(eq, not_unique);

+ STATIC_ASSERT(kInternalizedTag == 0);

+ __ tst(hash, Operand(kIsNotInternalizedMask));

+ __ b(ne, not_unique);

__ bind(&unique);

}

« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/arm/macro-assembler-arm.cc » ('j') | no next file with comments »