Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/ia32/macro-assembler-ia32.cc

Issue 19749004: With >= 64 non-string instance types, I removed an optimization (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Review comments Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/ic-ia32.cc ('k') | src/objects.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2794 matching lines...) Expand 10 before | Expand all | Expand 10 after
2805 and_(scratch2, kFlatAsciiStringMask); 2805 and_(scratch2, kFlatAsciiStringMask);
2806 lea(scratch1, Operand(scratch1, scratch2, times_8, 0)); 2806 lea(scratch1, Operand(scratch1, scratch2, times_8, 0));
2807 cmp(scratch1, kFlatAsciiStringTag | (kFlatAsciiStringTag << 3)); 2807 cmp(scratch1, kFlatAsciiStringTag | (kFlatAsciiStringTag << 3));
2808 j(not_equal, failure); 2808 j(not_equal, failure);
2809 } 2809 }
2810 2810
2811 2811
2812 void MacroAssembler::JumpIfNotUniqueName(Operand operand, 2812 void MacroAssembler::JumpIfNotUniqueName(Operand operand,
2813 Label* not_unique_name, 2813 Label* not_unique_name,
2814 Label::Distance distance) { 2814 Label::Distance distance) {
2815 STATIC_ASSERT(((SYMBOL_TYPE - 1) & kIsInternalizedMask) == kInternalizedTag); 2815 STATIC_ASSERT(kInternalizedTag == 0 && kStringTag == 0);
2816 cmp(operand, Immediate(kInternalizedTag)); 2816 Label succeed;
2817 j(less, not_unique_name, distance); 2817 test(operand, Immediate(kIsNotStringMask | kIsNotInternalizedMask));
2818 cmp(operand, Immediate(SYMBOL_TYPE)); 2818 j(zero, &succeed);
2819 j(greater, not_unique_name, distance); 2819 cmpb(operand, static_cast<uint8_t>(SYMBOL_TYPE));
2820 j(not_equal, not_unique_name, distance);
2821
2822 bind(&succeed);
2820 } 2823 }
2821 2824
2822 2825
2823 void MacroAssembler::PrepareCallCFunction(int num_arguments, Register scratch) { 2826 void MacroAssembler::PrepareCallCFunction(int num_arguments, Register scratch) {
2824 int frame_alignment = OS::ActivationFrameAlignment(); 2827 int frame_alignment = OS::ActivationFrameAlignment();
2825 if (frame_alignment != 0) { 2828 if (frame_alignment != 0) {
2826 // Make stack end at alignment and make room for num_arguments words 2829 // Make stack end at alignment and make room for num_arguments words
2827 // and the original value of esp. 2830 // and the original value of esp.
2828 mov(scratch, esp); 2831 mov(scratch, esp);
2829 sub(esp, Immediate((num_arguments + 1) * kPointerSize)); 2832 sub(esp, Immediate((num_arguments + 1) * kPointerSize));
(...skipping 351 matching lines...) Expand 10 before | Expand all | Expand 10 after
3181 j(greater, &no_info_available); 3184 j(greater, &no_info_available);
3182 cmp(MemOperand(scratch_reg, -AllocationSiteInfo::kSize), 3185 cmp(MemOperand(scratch_reg, -AllocationSiteInfo::kSize),
3183 Immediate(Handle<Map>(isolate()->heap()->allocation_site_info_map()))); 3186 Immediate(Handle<Map>(isolate()->heap()->allocation_site_info_map())));
3184 bind(&no_info_available); 3187 bind(&no_info_available);
3185 } 3188 }
3186 3189
3187 3190
3188 } } // namespace v8::internal 3191 } } // namespace v8::internal
3189 3192
3190 #endif // V8_TARGET_ARCH_IA32 3193 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/ic-ia32.cc ('k') | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698