Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: src/arm/macro-assembler-arm.cc

Issue 19749004: With >= 64 non-string instance types, I removed an optimization (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Review comments Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/ic-arm.cc ('k') | src/hydrogen-instructions.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3075 matching lines...) Expand 10 before | Expand all | Expand 10 after
3086 JumpIfNonSmisNotBothSequentialAsciiStrings(first, 3086 JumpIfNonSmisNotBothSequentialAsciiStrings(first,
3087 second, 3087 second,
3088 scratch1, 3088 scratch1,
3089 scratch2, 3089 scratch2,
3090 failure); 3090 failure);
3091 } 3091 }
3092 3092
3093 3093
3094 void MacroAssembler::JumpIfNotUniqueName(Register reg, 3094 void MacroAssembler::JumpIfNotUniqueName(Register reg,
3095 Label* not_unique_name) { 3095 Label* not_unique_name) {
3096 STATIC_ASSERT(((SYMBOL_TYPE - 1) & kIsInternalizedMask) == kInternalizedTag); 3096 STATIC_ASSERT(kInternalizedTag == 0 && kStringTag == 0);
3097 cmp(reg, Operand(kInternalizedTag)); 3097 Label succeed;
3098 b(lt, not_unique_name); 3098 tst(reg, Operand(kIsNotStringMask | kIsNotInternalizedMask));
3099 b(eq, &succeed);
3099 cmp(reg, Operand(SYMBOL_TYPE)); 3100 cmp(reg, Operand(SYMBOL_TYPE));
3100 b(gt, not_unique_name); 3101 b(ne, not_unique_name);
3102
3103 bind(&succeed);
3101 } 3104 }
3102 3105
3103 3106
3104 // Allocates a heap number or jumps to the need_gc label if the young space 3107 // Allocates a heap number or jumps to the need_gc label if the young space
3105 // is full and a scavenge is needed. 3108 // is full and a scavenge is needed.
3106 void MacroAssembler::AllocateHeapNumber(Register result, 3109 void MacroAssembler::AllocateHeapNumber(Register result,
3107 Register scratch1, 3110 Register scratch1,
3108 Register scratch2, 3111 Register scratch2,
3109 Register heap_number_map, 3112 Register heap_number_map,
3110 Label* gc_required, 3113 Label* gc_required,
(...skipping 717 matching lines...) Expand 10 before | Expand all | Expand 10 after
3828 void CodePatcher::EmitCondition(Condition cond) { 3831 void CodePatcher::EmitCondition(Condition cond) {
3829 Instr instr = Assembler::instr_at(masm_.pc_); 3832 Instr instr = Assembler::instr_at(masm_.pc_);
3830 instr = (instr & ~kCondMask) | cond; 3833 instr = (instr & ~kCondMask) | cond;
3831 masm_.emit(instr); 3834 masm_.emit(instr);
3832 } 3835 }
3833 3836
3834 3837
3835 } } // namespace v8::internal 3838 } } // namespace v8::internal
3836 3839
3837 #endif // V8_TARGET_ARCH_ARM 3840 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/arm/ic-arm.cc ('k') | src/hydrogen-instructions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698