Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Side by Side Diff: src/arm/ic-arm.cc

Issue 19749004: With >= 64 non-string instance types, I removed an optimization (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Review comments Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/arm/macro-assembler-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 307 matching lines...) Expand 10 before | Expand all | Expand 10 after
318 318
319 // Is the string an array index, with cached numeric value? 319 // Is the string an array index, with cached numeric value?
320 __ ldr(hash, FieldMemOperand(key, Name::kHashFieldOffset)); 320 __ ldr(hash, FieldMemOperand(key, Name::kHashFieldOffset));
321 __ tst(hash, Operand(Name::kContainsCachedArrayIndexMask)); 321 __ tst(hash, Operand(Name::kContainsCachedArrayIndexMask));
322 __ b(eq, index_string); 322 __ b(eq, index_string);
323 323
324 // Is the string internalized? We know it's a string, so a single 324 // Is the string internalized? We know it's a string, so a single
325 // bit test is enough. 325 // bit test is enough.
326 // map: key map 326 // map: key map
327 __ ldrb(hash, FieldMemOperand(map, Map::kInstanceTypeOffset)); 327 __ ldrb(hash, FieldMemOperand(map, Map::kInstanceTypeOffset));
328 STATIC_ASSERT(kInternalizedTag != 0); 328 STATIC_ASSERT(kInternalizedTag == 0);
329 __ tst(hash, Operand(kIsInternalizedMask)); 329 __ tst(hash, Operand(kIsNotInternalizedMask));
330 __ b(eq, not_unique); 330 __ b(ne, not_unique);
331 331
332 __ bind(&unique); 332 __ bind(&unique);
333 } 333 }
334 334
335 335
336 // Defined in ic.cc. 336 // Defined in ic.cc.
337 Object* CallIC_Miss(Arguments args); 337 Object* CallIC_Miss(Arguments args);
338 338
339 // The generated code does not accept smi keys. 339 // The generated code does not accept smi keys.
340 // The generated code falls through if both probes miss. 340 // The generated code falls through if both probes miss.
(...skipping 1357 matching lines...) Expand 10 before | Expand all | Expand 10 after
1698 } else { 1698 } else {
1699 ASSERT(Assembler::GetCondition(branch_instr) == ne); 1699 ASSERT(Assembler::GetCondition(branch_instr) == ne);
1700 patcher.EmitCondition(eq); 1700 patcher.EmitCondition(eq);
1701 } 1701 }
1702 } 1702 }
1703 1703
1704 1704
1705 } } // namespace v8::internal 1705 } } // namespace v8::internal
1706 1706
1707 #endif // V8_TARGET_ARCH_ARM 1707 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/arm/macro-assembler-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698