WebGL2 expectations: add initial webgl2 ANGLE expectations

WebGL2 expectations: add initial webgl2 ANGLE expectations

BUG=605775
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

patch from issue 1967803004 at patchset 1 (http://crrev.com/1967803004#ps1)

Committed: https://crrev.com/e697d11a7d65a9b61e64f0d91b6c8ede77a24542
Cr-Commit-Position: refs/heads/master@{#393603}

[Corentin Wallez, 2016-05-12 17:39:22]

cwallez@chromium.org changed reviewers:
+ kbr@chromium.org

[Corentin Wallez, 2016-05-12 17:39:23]

PTAL, recreate the CL with my chromium.org account instead of google.com account

[Ken Russell (switch to Gerrit), 2016-05-12 21:03:01]

https://codereview.chromium.org/1974893002/diff/1/content/test/gpu/gpu_tests/...
File content/test/gpu/gpu_tests/gpu_test_expectations.py (right):

https://codereview.chromium.org/1974893002/diff/1/content/test/gpu/gpu_tests/...
content/test/gpu/gpu_tests/gpu_test_expectations.py:96: angle_renderer in
expectation.angle_conditions)
Per comment on the other CL:

I think this logic needs to be updated to handle the 'no_angle' condition.
Otherwise, I'm pretty sure that any expectation which specifies it will never
match, since angle_renderer will be '' but expectation.angle_conditions will be
['no_angle'].

[Corentin Wallez, 2016-05-13 14:43:01]

On 2016/05/12 at 21:03:01, kbr wrote:
>
https://codereview.chromium.org/1974893002/diff/1/content/test/gpu/gpu_tests/...
> File content/test/gpu/gpu_tests/gpu_test_expectations.py (right):
> 
>
https://codereview.chromium.org/1974893002/diff/1/content/test/gpu/gpu_tests/...
> content/test/gpu/gpu_tests/gpu_test_expectations.py:96: angle_renderer in
expectation.angle_conditions)
> Per comment on the other CL:
> 
> I think this logic needs to be updated to handle the 'no_angle' condition.
Otherwise, I'm pretty sure that any expectation which specifies it will never
match, since angle_renderer will be '' but expectation.angle_conditions will be
['no_angle'].

Good catch, adressed the comment by returning 'no_angle' instead of '' when no
ANGLE renderer is found. Expectations not specifying an ANGLE renderer nor
'no_angle' will keep matching both ANGLE and non-ANGLE.

[Ken Russell (switch to Gerrit), 2016-05-13 17:59:07]

On 2016/05/13 14:43:01, Corentin Wallez wrote:
> On 2016/05/12 at 21:03:01, kbr wrote:
> >
>
https://codereview.chromium.org/1974893002/diff/1/content/test/gpu/gpu_tests/...
> > File content/test/gpu/gpu_tests/gpu_test_expectations.py (right):
> > 
> >
>
https://codereview.chromium.org/1974893002/diff/1/content/test/gpu/gpu_tests/...
> > content/test/gpu/gpu_tests/gpu_test_expectations.py:96: angle_renderer in
> expectation.angle_conditions)
> > Per comment on the other CL:
> > 
> > I think this logic needs to be updated to handle the 'no_angle' condition.
> Otherwise, I'm pretty sure that any expectation which specifies it will never
> match, since angle_renderer will be '' but expectation.angle_conditions will
be
> ['no_angle'].
> 
> Good catch, adressed the comment by returning 'no_angle' instead of '' when no
> ANGLE renderer is found. Expectations not specifying an ANGLE renderer nor
> 'no_angle' will keep matching both ANGLE and non-ANGLE.

Oh, sorry, it looks like I missed that fact. LGTM

[Corentin Wallez, 2016-05-13 18:09:46]

On 2016/05/13 at 17:59:07, kbr wrote:
> On 2016/05/13 14:43:01, Corentin Wallez wrote:
> > On 2016/05/12 at 21:03:01, kbr wrote:
> > >
> >
https://codereview.chromium.org/1974893002/diff/1/content/test/gpu/gpu_tests/...
> > > File content/test/gpu/gpu_tests/gpu_test_expectations.py (right):
> > > 
> > >
> >
https://codereview.chromium.org/1974893002/diff/1/content/test/gpu/gpu_tests/...
> > > content/test/gpu/gpu_tests/gpu_test_expectations.py:96: angle_renderer in
> > expectation.angle_conditions)
> > > Per comment on the other CL:
> > > 
> > > I think this logic needs to be updated to handle the 'no_angle' condition.
> > Otherwise, I'm pretty sure that any expectation which specifies it will
never
> > match, since angle_renderer will be '' but expectation.angle_conditions will
be
> > ['no_angle'].
> > 
> > Good catch, adressed the comment by returning 'no_angle' instead of '' when
no
> > ANGLE renderer is found. Expectations not specifying an ANGLE renderer nor
> > 'no_angle' will keep matching both ANGLE and non-ANGLE.
> 
> Oh, sorry, it looks like I missed that fact. LGTM

NP :)

[Corentin Wallez, 2016-05-13 18:09:48]

The CQ bit was checked by cwallez@chromium.org

[commit-bot: I haz the power, 2016-05-13 18:10:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1974893002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1974893002/1

[commit-bot: I haz the power, 2016-05-13 19:30:23]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-13 19:32:57]

Description was changed from

==========
WebGL2 expectations: add initial webgl2 ANGLE expectations

BUG=605775
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

patch from issue 1967803004 at patchset 1 (http://crrev.com/1967803004#ps1)
==========

to

==========
WebGL2 expectations: add initial webgl2 ANGLE expectations

BUG=605775
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

patch from issue 1967803004 at patchset 1 (http://crrev.com/1967803004#ps1)

Committed: https://crrev.com/e697d11a7d65a9b61e64f0d91b6c8ede77a24542
Cr-Commit-Position: refs/heads/master@{#393603}
==========

[commit-bot: I haz the power, 2016-05-13 19:32:58]

Patchset 1 (id:??) landed as
https://crrev.com/e697d11a7d65a9b61e64f0d91b6c8ede77a24542
Cr-Commit-Position: refs/heads/master@{#393603}