Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1327)

Unified Diff: runtime/vm/intrinsifier.cc

Issue 1974873002: Disable concurrent marking/sweeping, and background compilation on ARMv5TE (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: More shuffling things around Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/heap_test.cc ('k') | runtime/vm/pages.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intrinsifier.cc
diff --git a/runtime/vm/intrinsifier.cc b/runtime/vm/intrinsifier.cc
index 27631b37e96115b59d928c326b3499141fa1319f..bdd7c5c43cdd603e7961d0861e45dbeb3bb5d0a4 100644
--- a/runtime/vm/intrinsifier.cc
+++ b/runtime/vm/intrinsifier.cc
@@ -588,7 +588,9 @@ bool Intrinsifier::Build_Uint32ArrayGetIndexed(FlowGraph* flow_graph) {
bool Intrinsifier::Build_Float64ArraySetIndexed(FlowGraph* flow_graph) {
- if (!FlowGraphCompiler::SupportsUnboxedDoubles()) return false;
+ if (!FlowGraphCompiler::SupportsUnboxedDoubles()) {
+ return false;
+ }
GraphEntryInstr* graph_entry = flow_graph->graph_entry();
TargetEntryInstr* normal_entry = graph_entry->normal_entry();
@@ -634,7 +636,9 @@ bool Intrinsifier::Build_Float64ArraySetIndexed(FlowGraph* flow_graph) {
bool Intrinsifier::Build_Float64ArrayGetIndexed(FlowGraph* flow_graph) {
- if (!FlowGraphCompiler::SupportsUnboxedDoubles()) return false;
+ if (!FlowGraphCompiler::SupportsUnboxedDoubles()) {
+ return false;
+ }
GraphEntryInstr* graph_entry = flow_graph->graph_entry();
TargetEntryInstr* normal_entry = graph_entry->normal_entry();
@@ -783,7 +787,10 @@ bool Intrinsifier::Build_Float32x4Add(FlowGraph* flow_graph) {
static bool BuildFloat32x4Shuffle(FlowGraph* flow_graph,
MethodRecognizer::Kind kind) {
- if (!FlowGraphCompiler::SupportsUnboxedSimd128()) return false;
+ if (!FlowGraphCompiler::SupportsUnboxedDoubles() ||
+ !FlowGraphCompiler::SupportsUnboxedSimd128()) {
+ return false;
+ }
GraphEntryInstr* graph_entry = flow_graph->graph_entry();
TargetEntryInstr* normal_entry = graph_entry->normal_entry();
BlockBuilder builder(flow_graph, normal_entry);
@@ -1021,6 +1028,9 @@ bool Intrinsifier::Build_GrowableArraySetLength(FlowGraph* flow_graph) {
bool Intrinsifier::Build_DoubleFlipSignBit(FlowGraph* flow_graph) {
+ if (!FlowGraphCompiler::SupportsUnboxedDoubles()) {
+ return false;
+ }
GraphEntryInstr* graph_entry = flow_graph->graph_entry();
TargetEntryInstr* normal_entry = graph_entry->normal_entry();
BlockBuilder builder(flow_graph, normal_entry);
@@ -1044,6 +1054,9 @@ bool Intrinsifier::Build_DoubleFlipSignBit(FlowGraph* flow_graph) {
static bool BuildInvokeMathCFunction(BlockBuilder* builder,
MethodRecognizer::Kind kind,
intptr_t num_parameters = 1) {
+ if (!FlowGraphCompiler::SupportsUnboxedDoubles()) {
+ return false;
+ }
ZoneGrowableArray<Value*>* args =
new ZoneGrowableArray<Value*>(num_parameters);
« no previous file with comments | « runtime/vm/heap_test.cc ('k') | runtime/vm/pages.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698