Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: runtime/vm/pages.cc

Issue 1974873002: Disable concurrent marking/sweeping, and background compilation on ARMv5TE (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/gc_marker.cc ('K') | « runtime/vm/intrinsifier.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/pages.cc
diff --git a/runtime/vm/pages.cc b/runtime/vm/pages.cc
index 64b1d5e91f7d342c85cc9622fba2cd1d72c9db40..5609a6e0096a7f885ea86c1c1a1c789a14ceaf12 100644
--- a/runtime/vm/pages.cc
+++ b/runtime/vm/pages.cc
@@ -17,6 +17,14 @@
namespace dart {
+// Disable concurrent sweeping by default on armv5te. The relevant
+// implementations are uniprocessors.
+#if defined(TARGET_ARCH_ARM_5TE)
+#define USING_CONCURRENT_SWEEP false
+#else
+#define USING_CONCURRENT_SWEEP true
+#endif
+
DEFINE_FLAG(int, heap_growth_rate, 0,
"The max number of pages the heap can grow at a time");
DEFINE_FLAG(int, old_gen_growth_space_ratio, 20,
@@ -35,7 +43,7 @@ DEFINE_FLAG(bool, log_code_drop, false,
"Emit a log message when pointers to unused code are dropped.");
DEFINE_FLAG(bool, always_drop_code, false,
"Always try to drop code if the function's usage counter is >= 0");
-DEFINE_FLAG(bool, concurrent_sweep, true,
+DEFINE_FLAG(bool, concurrent_sweep, USING_CONCURRENT_SWEEP,
Ivan Posva 2016/05/12 17:19:46 ditto
zra 2016/05/12 19:54:21 Done.
zra 2016/05/12 19:59:11 That is, I moved concurrent_sweep. Moving the othe
"Concurrent sweep for old generation.");
DEFINE_FLAG(bool, log_growth, false, "Log PageSpace growth policy decisions.");
« runtime/vm/gc_marker.cc ('K') | « runtime/vm/intrinsifier.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698