Disable concurrent marking/sweeping, and background compilation on ARMv5TE

Disable concurrent marking/sweeping, and background compilation on ARMv5TE

Also adds missing feature detection to the graph intrinsifier.

R=iposva@google.com, johnmccutchan@google.com

Committed: https://github.com/dart-lang/sdk/commit/f82a8c9af2d940451fa5daf9ff6ae5026af1a2e9

[zra, 2016-05-12 16:45:44]

zra@google.com changed reviewers:
+ iposva@google.com, johnmccutchan@google.com

[Cutch, 2016-05-12 16:48:49]

lgtm

[Ivan Posva, 2016-05-12 17:19:46]

Once the flags are moved we can have them be driven by a single define such as
ARCH_IS_MULTI_CORE which we should define in a globals.h.

-Ivan

https://codereview.chromium.org/1974873002/diff/1/runtime/vm/gc_marker.cc
File runtime/vm/gc_marker.cc (right):

https://codereview.chromium.org/1974873002/diff/1/runtime/vm/gc_marker.cc#new...
runtime/vm/gc_marker.cc:36: DEFINE_FLAG(int, marker_tasks, MARKER_TASKS,
Can we please move these flags into the flag list?

https://codereview.chromium.org/1974873002/diff/1/runtime/vm/pages.cc
File runtime/vm/pages.cc (right):

https://codereview.chromium.org/1974873002/diff/1/runtime/vm/pages.cc#newcode46
runtime/vm/pages.cc:46: DEFINE_FLAG(bool, concurrent_sweep,
USING_CONCURRENT_SWEEP,
ditto

[zra, 2016-05-12 19:54:22]

https://codereview.chromium.org/1974873002/diff/1/runtime/vm/gc_marker.cc
File runtime/vm/gc_marker.cc (right):

https://codereview.chromium.org/1974873002/diff/1/runtime/vm/gc_marker.cc#new...
runtime/vm/gc_marker.cc:36: DEFINE_FLAG(int, marker_tasks, MARKER_TASKS,
On 2016/05/12 17:19:46, Ivan Posva wrote:
> Can we please move these flags into the flag list?

Done.

https://codereview.chromium.org/1974873002/diff/1/runtime/vm/pages.cc
File runtime/vm/pages.cc (right):

https://codereview.chromium.org/1974873002/diff/1/runtime/vm/pages.cc#newcode46
runtime/vm/pages.cc:46: DEFINE_FLAG(bool, concurrent_sweep,
USING_CONCURRENT_SWEEP,
On 2016/05/12 17:19:46, Ivan Posva wrote:
> ditto

Done.

[zra, 2016-05-12 19:59:11]

https://codereview.chromium.org/1974873002/diff/1/runtime/vm/pages.cc
File runtime/vm/pages.cc (right):

https://codereview.chromium.org/1974873002/diff/1/runtime/vm/pages.cc#newcode46
runtime/vm/pages.cc:46: DEFINE_FLAG(bool, concurrent_sweep,
USING_CONCURRENT_SWEEP,
On 2016/05/12 19:54:21, zra wrote:
> On 2016/05/12 17:19:46, Ivan Posva wrote:
> > ditto
> 
> Done.

That is, I moved concurrent_sweep. Moving the others, and changing some to
Release and Debug mode flags, broke the Product mode build a lot, so I'll make a
separate change to track everything down.

[Ivan Posva, 2016-05-12 19:59:46]

-Ivan

https://codereview.chromium.org/1974873002/diff/20001/runtime/vm/flag_list.h
File runtime/vm/flag_list.h (right):

https://codereview.chromium.org/1974873002/diff/20001/runtime/vm/flag_list.h#...
runtime/vm/flag_list.h:14: // Disable background threads by default on armv5te.
The relevant
Please move this into platform/globals.h instead of it hiding here in
flag_list.h.

[zra, 2016-05-12 20:12:26]

https://codereview.chromium.org/1974873002/diff/20001/runtime/vm/flag_list.h
File runtime/vm/flag_list.h (right):

https://codereview.chromium.org/1974873002/diff/20001/runtime/vm/flag_list.h#...
runtime/vm/flag_list.h:14: // Disable background threads by default on armv5te.
The relevant
On 2016/05/12 19:59:46, Ivan Posva wrote:
> Please move this into platform/globals.h instead of it hiding here in
> flag_list.h.

Done.

[Ivan Posva, 2016-05-12 21:44:34]

LGTM after making the changes discussed in person.

-Ivan

[zra, 2016-05-12 22:07:53]

On 2016/05/12 21:44:34, Ivan Posva wrote:
> LGTM after making the changes discussed in person.
> 
> -Ivan

The symbols can't be undef'd in the header file because they then won't be
available when the FLAG_LIST macro is expanded. Instead I have added comments
warning against using USING_DBC and USING_MULTICORE.

[zra, 2016-05-12 22:09:45]

Description was changed from

==========
Disable concurrent marking/sweeping, and background compilation on ARMv5TE

Also adds missing feature detection to the graph intrinsifier.
==========

to

==========
Disable concurrent marking/sweeping, and background compilation on ARMv5TE

Also adds missing feature detection to the graph intrinsifier.

R=iposva@google.com, johnmccutchan@google.com

Committed:
https://github.com/dart-lang/sdk/commit/f82a8c9af2d940451fa5daf9ff6ae5026af1a2e9
==========

[zra, 2016-05-12 22:09:47]

Committed patchset #5 (id:80001) manually as
f82a8c9af2d940451fa5daf9ff6ae5026af1a2e9.