Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1974823003: DevTools: fix disappearing separator in rendering drawer (Closed)

Created:
4 years, 7 months ago by luoe
Modified:
4 years, 7 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: fix disappearing separator in rendering drawer BUG=610947 Committed: https://crrev.com/05ed45464fe989a920938ec597d371306c1f6f72 Cr-Commit-Position: refs/heads/master@{#394005}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/Source/devtools/front_end/main/renderingOptions.css View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
luoe
The separator had no flex value, but was squeezed in between other elements that did.
4 years, 7 months ago (2016-05-12 21:55:40 UTC) #2
lushnikov
lgtm
4 years, 7 months ago (2016-05-16 21:52:09 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1974823003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1974823003/1
4 years, 7 months ago (2016-05-16 21:59:07 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/228582)
4 years, 7 months ago (2016-05-16 23:23:06 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1974823003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1974823003/1
4 years, 7 months ago (2016-05-17 00:08:34 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-17 00:50:28 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1974823003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1974823003/1
4 years, 7 months ago (2016-05-17 01:21:12 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-17 01:26:03 UTC) #14
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 01:27:37 UTC) #16
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/05ed45464fe989a920938ec597d371306c1f6f72
Cr-Commit-Position: refs/heads/master@{#394005}

Powered by Google App Engine
This is Rietveld 408576698