Issue 19748: Ensure that the proper UA string is set while in incognito mode....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19748: Ensure that the proper UA string is set while in incognito mode.... (Closed)

Created:
11 years, 10 months ago by darin (slow to review)

Modified:
9 years, 7 months ago

Reviewers:
laforge, wtc

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/branches/release_154.next/src/chrome/browser/

Visibility:
Public.

Description

Ensure that the proper UA string is set while in incognito mode. It turns out that OffTheRecordRequestContext only exists on the 1.0 branch, which is why this change isn't applicable to the trunk. This patch is very simple: we just need to ask the real URLRequestContext to provide the UA string on behalf of the incognito URLRequestContext. R=wtc BUG=7279

Patch Set 1 #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	profile.cc	View		2 chunks	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM!

Expand Messages | Collapse Messages