Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years, 7 months ago by Jakob Kummerow Modified:
4 years, 7 months ago Reviewers:
Toon Verwaest CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[IC] Only cache handlers on a map that were compiled for that map
Globally cached handler stubs shouldn't be put into the on-map caches.
This should speed up IC misses and save a bit of memory.
Drive-by fix: transitioning StoreIC handlers were erroneously never cached.
Committed: https://crrev.com/8313d2f0cb041155eedd9c3749ddf80c5b392965
Cr-Commit-Position: refs/heads/master@{#36247}
Patch Set 1 #Patch Set 2 : #Patch Set 3 : rebase #Patch Set 4 : make gcc happy #
Created: 4 years, 7 months ago
Messages
Total messages: 18 (9 generated)
jkummerow@chromium.org changed reviewers: + verwaest@chromium.org
As discussed. PTAL. Some of the conditions could be simplified when looked at in isolation, but I wanted GetMapIndependentHandler() and CompileHandler() to follow the same control-flow structure, so when viewing them side-by-side it's easy to verify that they match up.
lgtm
The CQ bit was checked by jkummerow@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1974793002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1974793002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...) v8_linux64_asan_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...) v8_linux64_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/5720) v8_linux_arm64_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...) v8_linux_arm_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...) v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...) v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...) v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...) v8_linux_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/5709) v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/15204)
The CQ bit was checked by jkummerow@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from verwaest@chromium.org Link to the patchset: https://codereview.chromium.org/1974793002/#ps40001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1974793002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1974793002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
The CQ bit was checked by jkummerow@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from verwaest@chromium.org Link to the patchset: https://codereview.chromium.org/1974793002/#ps60001 (title: "make gcc happy")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1974793002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1974793002/60001
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== [IC] Only cache handlers on a map that were compiled for that map Globally cached handler stubs shouldn't be put into the on-map caches. This should speed up IC misses and save a bit of memory. Drive-by fix: transitioning StoreIC handlers were erroneously never cached. ========== to ========== [IC] Only cache handlers on a map that were compiled for that map Globally cached handler stubs shouldn't be put into the on-map caches. This should speed up IC misses and save a bit of memory. Drive-by fix: transitioning StoreIC handlers were erroneously never cached. Committed: https://crrev.com/8313d2f0cb041155eedd9c3749ddf80c5b392965 Cr-Commit-Position: refs/heads/master@{#36247} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/8313d2f0cb041155eedd9c3749ddf80c5b392965 Cr-Commit-Position: refs/heads/master@{#36247} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
