[IC] Only cache handlers on a map that were compiled for that map

[IC] Only cache handlers on a map that were compiled for that map

Globally cached handler stubs shouldn't be put into the on-map caches.
This should speed up IC misses and save a bit of memory.

Drive-by fix: transitioning StoreIC handlers were erroneously never cached.

Committed: https://crrev.com/8313d2f0cb041155eedd9c3749ddf80c5b392965
Cr-Commit-Position: refs/heads/master@{#36247}

[Jakob Kummerow, 2016-05-12 13:49:54]

jkummerow@chromium.org changed reviewers:
+ verwaest@chromium.org

[Jakob Kummerow, 2016-05-12 13:49:54]

As discussed. PTAL.

Some of the conditions could be simplified when looked at in isolation, but I
wanted GetMapIndependentHandler() and CompileHandler() to follow the same
control-flow structure, so when viewing them side-by-side it's easy to verify
that they match up.

[Toon Verwaest, 2016-05-13 08:14:22]

lgtm

[Jakob Kummerow, 2016-05-13 09:21:34]

The CQ bit was checked by jkummerow@chromium.org

[commit-bot: I haz the power, 2016-05-13 09:21:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1974793002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1974793002/20001

[commit-bot: I haz the power, 2016-05-13 09:22:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-13 09:22:53]

Try jobs failed on following builders:
  v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux64_asan_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/5720)
  v8_linux_arm64_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_arm_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/5709)
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/15204)

[Jakob Kummerow, 2016-05-13 13:00:40]

The CQ bit was checked by jkummerow@chromium.org

[Jakob Kummerow, 2016-05-13 13:00:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
verwaest@chromium.org
Link to the patchset: https://codereview.chromium.org/1974793002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-05-13 13:00:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1974793002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1974793002/40001

[commit-bot: I haz the power, 2016-05-13 13:13:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-13 13:13:52]

Try jobs failed on following builders:
  v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)

[Jakob Kummerow, 2016-05-13 14:32:48]

The CQ bit was checked by jkummerow@chromium.org

[Jakob Kummerow, 2016-05-13 14:32:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
verwaest@chromium.org
Link to the patchset: https://codereview.chromium.org/1974793002/#ps60001
(title: "make gcc happy")

[commit-bot: I haz the power, 2016-05-13 14:32:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1974793002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1974793002/60001

[commit-bot: I haz the power, 2016-05-13 15:01:00]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-13 15:02:37]

Description was changed from

==========
[IC] Only cache handlers on a map that were compiled for that map

Globally cached handler stubs shouldn't be put into the on-map caches.
This should speed up IC misses and save a bit of memory.

Drive-by fix: transitioning StoreIC handlers were erroneously never cached.
==========

to

==========
[IC] Only cache handlers on a map that were compiled for that map

Globally cached handler stubs shouldn't be put into the on-map caches.
This should speed up IC misses and save a bit of memory.

Drive-by fix: transitioning StoreIC handlers were erroneously never cached.

Committed: https://crrev.com/8313d2f0cb041155eedd9c3749ddf80c5b392965
Cr-Commit-Position: refs/heads/master@{#36247}
==========

[commit-bot: I haz the power, 2016-05-13 15:02:38]

Patchset 4 (id:??) landed as
https://crrev.com/8313d2f0cb041155eedd9c3749ddf80c5b392965
Cr-Commit-Position: refs/heads/master@{#36247}