Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 1974753002: Move block container specific parts of addChild() to LayoutBlockFlow. (Closed)

Created:
4 years, 7 months ago by mstensho (USE GERRIT)
Modified:
4 years, 7 months ago
Reviewers:
eae, szager1, wkorman
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move block container specific parts of addChild() to LayoutBlockFlow. LayoutBlock still needs some basic support for anonymous block insertion, for flexbox, and possibly others. BUG=302024 Committed: https://crrev.com/e39905e1d6708f291f89a47330892b7810f39d80 Cr-Commit-Position: refs/heads/master@{#393266}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -24 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 2 chunks +4 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 1 chunk +58 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
mstensho (USE GERRIT)
4 years, 7 months ago (2016-05-12 12:42:06 UTC) #2
eae
LGTM Thanks for doing this Morten!
4 years, 7 months ago (2016-05-12 16:18:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1974753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1974753002/1
4 years, 7 months ago (2016-05-12 16:19:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-12 16:22:57 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 16:25:06 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e39905e1d6708f291f89a47330892b7810f39d80
Cr-Commit-Position: refs/heads/master@{#393266}

Powered by Google App Engine
This is Rietveld 408576698