[Material][Mac] Remove NSVisualEffectView from windows with titlebars

[Material][Mac] Remove NSVisualEffectView from windows with titlebars

BUG=607356
Committed: https://crrev.com/32810807ecda6e6a65666c7ec66590b02e89167f
Cr-Commit-Position: refs/heads/master@{#393664}

[spqchan, 2016-05-12 23:19:29]

spqchan@chromium.org changed reviewers:
+ shrike@chromium.org

[spqchan, 2016-05-12 23:19:30]

PTAL

[shrike, 2016-05-13 18:30:21]

https://codereview.chromium.org/1974733003/diff/1/chrome/browser/ui/cocoa/tab...
File chrome/browser/ui/cocoa/tabs/tab_window_controller.mm (right):

https://codereview.chromium.org/1974733003/diff/1/chrome/browser/ui/cocoa/tab...
chrome/browser/ui/cocoa/tabs/tab_window_controller.mm:356: [window
setTitlebarAppearsTransparent:YES];
What happens in the title-bar case if you don't do this?

[spqchan, 2016-05-13 20:15:00]

On 2016/05/13 18:30:21, shrike wrote:
>
https://codereview.chromium.org/1974733003/diff/1/chrome/browser/ui/cocoa/tab...
> File chrome/browser/ui/cocoa/tabs/tab_window_controller.mm (right):
> 
>
https://codereview.chromium.org/1974733003/diff/1/chrome/browser/ui/cocoa/tab...
> chrome/browser/ui/cocoa/tabs/tab_window_controller.mm:356: [window
> setTitlebarAppearsTransparent:YES];
> What happens in the title-bar case if you don't do this?

Normal NSWindow titlebar effects get applied

https://screenshot.googleplex.com/MhyPpCiFkEv.png

[shrike, 2016-05-13 20:31:48]

On 2016/05/13 20:15:00, spqchan wrote:
> On 2016/05/13 18:30:21, shrike wrote:
> >
>
https://codereview.chromium.org/1974733003/diff/1/chrome/browser/ui/cocoa/tab...
> > File chrome/browser/ui/cocoa/tabs/tab_window_controller.mm (right):
> > 
> >
>
https://codereview.chromium.org/1974733003/diff/1/chrome/browser/ui/cocoa/tab...
> > chrome/browser/ui/cocoa/tabs/tab_window_controller.mm:356: [window
> > setTitlebarAppearsTransparent:YES];
> > What happens in the title-bar case if you don't do this?
> 
> Normal NSWindow titlebar effects get applied
> 
> https://screenshot.googleplex.com/MhyPpCiFkEv.png

OK, thank you. LGTM

BTW, you should append your replies to the original comment rather than hit
Reply on the main cl page. That way the discussion about a particular point
remains contained in one place.

[spqchan, 2016-05-13 20:42:17]

spqchan@chromium.org changed reviewers:
+ avi@chromium.org

[spqchan, 2016-05-13 20:42:18]

+avi for OWNERS

[Avi (use Gerrit), 2016-05-13 21:43:02]

lgtm

[spqchan, 2016-05-13 21:51:17]

The CQ bit was checked by spqchan@chromium.org

[commit-bot: I haz the power, 2016-05-13 21:51:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1974733003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1974733003/1

[commit-bot: I haz the power, 2016-05-13 22:52:06]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-13 22:53:33]

Description was changed from

==========
[Material][Mac] Remove NSVisualEffectView from windows with titlebars

BUG=607356
==========

to

==========
[Material][Mac] Remove NSVisualEffectView from windows with titlebars

BUG=607356

Committed: https://crrev.com/32810807ecda6e6a65666c7ec66590b02e89167f
Cr-Commit-Position: refs/heads/master@{#393664}
==========

[commit-bot: I haz the power, 2016-05-13 22:53:34]

Patchset 1 (id:??) landed as
https://crrev.com/32810807ecda6e6a65666c7ec66590b02e89167f
Cr-Commit-Position: refs/heads/master@{#393664}