Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 1974733003: [Material][Mac] Remove NSVisualEffectView from windows with titlebars (Closed)

Created:
4 years, 7 months ago by spqchan
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Material][Mac] Remove NSVisualEffectView from windows with titlebars BUG=607356 Committed: https://crrev.com/32810807ecda6e6a65666c7ec66590b02e89167f Cr-Commit-Position: refs/heads/master@{#393664}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -8 lines) Patch
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_window_controller.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_window_controller.mm View 6 chunks +13 lines, -6 lines 1 comment Download

Messages

Total messages: 13 (4 generated)
spqchan
PTAL
4 years, 7 months ago (2016-05-12 23:19:30 UTC) #2
shrike
https://codereview.chromium.org/1974733003/diff/1/chrome/browser/ui/cocoa/tabs/tab_window_controller.mm File chrome/browser/ui/cocoa/tabs/tab_window_controller.mm (right): https://codereview.chromium.org/1974733003/diff/1/chrome/browser/ui/cocoa/tabs/tab_window_controller.mm#newcode356 chrome/browser/ui/cocoa/tabs/tab_window_controller.mm:356: [window setTitlebarAppearsTransparent:YES]; What happens in the title-bar case if ...
4 years, 7 months ago (2016-05-13 18:30:21 UTC) #3
spqchan
On 2016/05/13 18:30:21, shrike wrote: > https://codereview.chromium.org/1974733003/diff/1/chrome/browser/ui/cocoa/tabs/tab_window_controller.mm > File chrome/browser/ui/cocoa/tabs/tab_window_controller.mm (right): > > https://codereview.chromium.org/1974733003/diff/1/chrome/browser/ui/cocoa/tabs/tab_window_controller.mm#newcode356 > ...
4 years, 7 months ago (2016-05-13 20:15:00 UTC) #4
shrike
On 2016/05/13 20:15:00, spqchan wrote: > On 2016/05/13 18:30:21, shrike wrote: > > > https://codereview.chromium.org/1974733003/diff/1/chrome/browser/ui/cocoa/tabs/tab_window_controller.mm ...
4 years, 7 months ago (2016-05-13 20:31:48 UTC) #5
spqchan
+avi for OWNERS
4 years, 7 months ago (2016-05-13 20:42:18 UTC) #7
Avi (use Gerrit)
lgtm
4 years, 7 months ago (2016-05-13 21:43:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1974733003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1974733003/1
4 years, 7 months ago (2016-05-13 21:51:50 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-13 22:52:06 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 22:53:34 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/32810807ecda6e6a65666c7ec66590b02e89167f
Cr-Commit-Position: refs/heads/master@{#393664}

Powered by Google App Engine
This is Rietveld 408576698