Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/FeedbackReportingView.java

Issue 197473006: Add FeedbackReporter for reporting distillation quality. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed disableUI again and comment Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/FeedbackReportingView.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/FeedbackReportingView.java b/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/FeedbackReportingView.java
new file mode 100644
index 0000000000000000000000000000000000000000..59e178c618aee16abe7a152007cc67035e8e8a48
--- /dev/null
+++ b/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/FeedbackReportingView.java
@@ -0,0 +1,142 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.chrome.browser.dom_distiller;
+
+import android.content.Context;
+import android.util.AttributeSet;
+import android.view.LayoutInflater;
+import android.view.MotionEvent;
+import android.view.View;
+import android.widget.ImageButton;
+
+import org.chromium.chrome.R;
+import org.chromium.chrome.browser.banners.SwipableOverlayView;
+import org.chromium.content.browser.ContentView;
+
+/**
+ * A view which displays a question to the user about the quality of distillation, where the user
+ * is given the option to respond.
+ *
+ * <p>The observer is called when the user makes a choice. After this point, it is not possible to
+ * interact with the view, and it is ready for dismissal. The selected option stays visibly
+ * selected.
+ */
+public class FeedbackReportingView extends SwipableOverlayView {
+ // XML layout for the BannerView.
+ private static final int VIEW_LAYOUT = R.layout.feedback_reporting_view;
+
+ // Class to alert about FeedbackReportingView events.
+ private FeedbackObserver mFeedbackObserver;
+
+ // The button to click for selecting 'No'.
+ private ImageButton mNoButton;
+
+ // The button to click for selecting 'Yes'.
+ private ImageButton mYesButton;
+
+ // Whether a selection has already been made, which means new events should be ignored.
+ private boolean mSelectionMade;
+
+ /**
+ * Called when the user makes a choice. After the call, it is not possible to interact further
+ * with the view.
+ */
+ interface FeedbackObserver {
+ void onYesPressed(FeedbackReportingView view);
+
+ void onNoPressed(FeedbackReportingView view);
+ }
+
+ /**
+ * Creates a FeedbackReportingView and adds it to the given ContentView.
+ *
+ * @param contentView ContentView to display the FeedbackReportingView for.
+ * @param feedbackObserver Class that is alerted for FeedbackReportingView events.
+ * @return The created banner.
+ */
+ public static FeedbackReportingView create(ContentView contentView,
+ FeedbackObserver feedbackObserver) {
+ Context context = contentView.getContext().getApplicationContext();
+ FeedbackReportingView banner =
+ (FeedbackReportingView) LayoutInflater.from(context).inflate(VIEW_LAYOUT, null);
+ banner.initialize(feedbackObserver);
+ banner.addToView(contentView);
+ return banner;
+ }
+
+ /**
+ * Creates a FeedbackReportingView.
+ *
+ * @param context Context for acquiring resources.
+ * @param attrs Attributes from the XML layout inflation.
+ */
+ public FeedbackReportingView(Context context, AttributeSet attrs) {
+ super(context, attrs);
+ }
+
+ private void initialize(FeedbackObserver feedbackObserver) {
+ mFeedbackObserver = feedbackObserver;
+ mNoButton = (ImageButton) findViewById(R.id.distillation_quality_answer_no);
+ mYesButton = (ImageButton) findViewById(R.id.distillation_quality_answer_yes);
+ mNoButton.setClickable(true);
+ mYesButton.setClickable(true);
+ mNoButton.setOnClickListener(new OnClickListener() {
+ @Override
+ public void onClick(View v) {
+ if (mSelectionMade) return;
+ mSelectionMade = true;
+ mNoButton.setImageResource(R.drawable.distillation_quality_answer_no_pressed);
+ disableUI();
+ if (mFeedbackObserver != null) {
+ mFeedbackObserver.onNoPressed(FeedbackReportingView.this);
+ }
+ }
+ });
+ mYesButton.setOnClickListener(new OnClickListener() {
+ @Override
+ public void onClick(View v) {
+ if (mSelectionMade) return;
+ mSelectionMade = true;
+ mYesButton.setImageResource(R.drawable.distillation_quality_answer_yes_pressed);
+ disableUI();
+ if (mFeedbackObserver != null) {
+ mFeedbackObserver.onYesPressed(FeedbackReportingView.this);
+ }
+ }
+ });
+ }
+
+ private void disableUI() {
+ // Clear OnClickListener to assure no more calls and that everything is cleaned up.
+ mNoButton.setOnClickListener(null);
+ mYesButton.setOnClickListener(null);
+
+ // Disable the buttons, so the images for highlighted/non-highlighted will not change if the
+ // user continues to tap the buttons while it is dismissing.
+ mNoButton.setEnabled(false);
+ mYesButton.setEnabled(false);
+ }
+
+ /**
+ * This is overridden since the method visibility is protected in the parent
+ * {@link SwipableOverlayView}. The
+ * {@link org.chromium.chrome.browser.dom_distiller.FeedbackReporter} needs to be able to
+ * dismiss this {@link org.chromium.chrome.browser.dom_distiller.FeedbackReportingView}, so by
+ * overriding this method in this class, it is callable from
+ * {@link org.chromium.chrome.browser.dom_distiller.FeedbackReporter}.
+ */
+ @Override
+ protected void dismiss() {
+ super.dismiss();
+ }
+
+ @Override
+ protected void onViewClicked() {
+ }
+
+ @Override
+ protected void onViewPressed(MotionEvent event) {
+ }
+}

Powered by Google App Engine
This is Rietveld 408576698