chrome/android/java/src/org/chromium/chrome/browser/banners/SwipableOverlayView.java - Issue 197473006: Add FeedbackReporter for reporting distillation quality.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/banners/SwipableOverlayView.java

Issue 197473006: Add FeedbackReporter for reporting distillation quality. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Updated implementation with UI Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/res/layout/feedback_reporting_view.xml ('K') | « chrome/android/java/src/org/chromium/chrome/browser/Tab.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/FeedbackReporter.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/FeedbackReporter.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/banners/SwipableOverlayView.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/banners/SwipableOverlayView.java b/chrome/android/java/src/org/chromium/chrome/browser/banners/SwipableOverlayView.java

index dc6728c713aa97b0e21de9f5d28b8c0af773db7d..ce3afbe5e29bb29f5c98c297a471afeeb05adcee 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/banners/SwipableOverlayView.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/banners/SwipableOverlayView.java

@@ -387,7 +387,7 @@ public abstract class SwipableOverlayView extends FrameLayout {

/**

* Dismisses the View, animating it moving vertically off of the screen if needed.

- void dismiss() {

+ protected void dismiss() {

if (getParent() == null) return;

float translationY = mTotalHeight;