chromecast/net/connectivity_checker_impl.h - Issue 1974723002: [Chromecast] Add metric reporting to ConnectivityCheckerImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/net/connectivity_checker_impl.h

Issue 1974723002: [Chromecast] Add metric reporting to ConnectivityCheckerImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Add CastMetricsHelper::RecordEventWithValue Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chromecast/base/metrics/cast_metrics_helper.cc ('k') | chromecast/net/connectivity_checker_impl.cc » ('j') | chromecast/net/connectivity_checker_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromecast/net/connectivity_checker_impl.h

diff --git a/chromecast/net/connectivity_checker_impl.h b/chromecast/net/connectivity_checker_impl.h

index f600cb7bcfb3b5bc3d8f8f7d548a379da8cd489e..917545dc57b165c1f05dde75fbbdc18d0712b52a 100644

--- a/chromecast/net/connectivity_checker_impl.h

+++ b/chromecast/net/connectivity_checker_impl.h

@@ -65,8 +65,14 @@ class ConnectivityCheckerImpl

// Sets connectivity and alerts observers if it has changed

void SetConnected(bool connected);

+ enum class ErrorType {

+ BAD_HTTP_STATUS = 1,

+ SSL_CERTIFICATE_ERROR = 2,

+ REQUEST_TIMEOUT = 3,

+ };

// Called when URL request failed.

- void OnUrlRequestError();

+ void OnUrlRequestError(ErrorType type);

// Called when URL request timed out.

void OnUrlRequestTimeout();