Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: chromecast/base/metrics/cast_metrics_helper.cc

Issue 1974723002: [Chromecast] Add metric reporting to ConnectivityCheckerImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Add CastMetricsHelper::RecordEventWithValue Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/base/metrics/cast_metrics_helper.cc
diff --git a/chromecast/base/metrics/cast_metrics_helper.cc b/chromecast/base/metrics/cast_metrics_helper.cc
index ac8b7b8f1f2a13511590d4085255ca7c90a3953d..6218456d3ed5e8e8f76f891236163f4af04c94ae 100644
--- a/chromecast/base/metrics/cast_metrics_helper.cc
+++ b/chromecast/base/metrics/cast_metrics_helper.cc
@@ -48,6 +48,16 @@ std::unique_ptr<std::string> SerializeToJson(const base::Value& value) {
return json_str;
}
+std::unique_ptr<base::DictionaryValue> CreateEventBase(
+ const std::string& name) {
+ std::unique_ptr<base::DictionaryValue> cast_event(
+ new base::DictionaryValue());
+ cast_event->SetString("name", name);
+ cast_event->SetDouble("time", base::TimeTicks::Now().ToInternalValue());
+
+ return cast_event;
+}
+
} // namespace
// static
@@ -291,32 +301,32 @@ void CastMetricsHelper::LogMediumTimeHistogramEvent(
50);
}
+void CastMetricsHelper::RecordEventWithValue(const std::string& event,
+ int value) {
+ std::unique_ptr<base::DictionaryValue> cast_event(CreateEventBase(event));
+ cast_event->SetInteger("value", value);
+ const std::string message = *SerializeToJson(*cast_event);
+ RecordSimpleAction(message);
+}
+
void CastMetricsHelper::RecordApplicationEvent(const std::string& event) {
- std::unique_ptr<base::DictionaryValue> cast_event(
- new base::DictionaryValue());
- cast_event->SetString("name", event);
- base::TimeTicks now = base::TimeTicks::Now();
- cast_event->SetDouble("time", now.ToInternalValue());
+ std::unique_ptr<base::DictionaryValue> cast_event(CreateEventBase(event));
cast_event->SetString("app_id", app_id_);
cast_event->SetString("session_id", session_id_);
cast_event->SetString("sdk_version", sdk_version_);
- const std::string message = *SerializeToJson(*cast_event.get()).get();
+ const std::string message = *SerializeToJson(*cast_event);
RecordSimpleAction(message);
}
void CastMetricsHelper::RecordApplicationEventWithValue(
const std::string& event,
int value) {
- std::unique_ptr<base::DictionaryValue> cast_event(
- new base::DictionaryValue());
- cast_event->SetString("name", event);
- base::TimeTicks now = base::TimeTicks::Now();
- cast_event->SetDouble("time", now.ToInternalValue());
+ std::unique_ptr<base::DictionaryValue> cast_event(CreateEventBase(event));
cast_event->SetString("app_id", app_id_);
cast_event->SetString("session_id", session_id_);
cast_event->SetString("sdk_version", sdk_version_);
cast_event->SetInteger("value", value);
- const std::string message = *SerializeToJson(*cast_event.get()).get();
+ const std::string message = *SerializeToJson(*cast_event);
RecordSimpleAction(message);
}

Powered by Google App Engine
This is Rietveld 408576698