Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: chromecast/net/connectivity_checker_impl.h

Issue 1974723002: [Chromecast] Add metric reporting to ConnectivityCheckerImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/net/connectivity_checker_impl.h
diff --git a/chromecast/net/connectivity_checker_impl.h b/chromecast/net/connectivity_checker_impl.h
index f600cb7bcfb3b5bc3d8f8f7d548a379da8cd489e..d3c4308796c877f60e4cf7e4321bf560cce1ec05 100644
--- a/chromecast/net/connectivity_checker_impl.h
+++ b/chromecast/net/connectivity_checker_impl.h
@@ -65,12 +65,20 @@ class ConnectivityCheckerImpl
// Sets connectivity and alerts observers if it has changed
void SetConnected(bool connected);
+ enum class ErrorType {
+ BAD_HTTP_STATUS = 1,
+ SSL_CERTIFICATE_ERROR = 2,
+ REQUEST_TIMEOUT = 3,
+ };
+
// Called when URL request failed.
- void OnUrlRequestError();
+ void OnUrlRequestError(ErrorType type);
// Called when URL request timed out.
void OnUrlRequestTimeout();
+ void RecordNetworkConnectivityErrorType(ErrorType type);
+
std::unique_ptr<GURL> connectivity_check_url_;
std::unique_ptr<net::URLRequestContext> url_request_context_;
std::unique_ptr<net::URLRequest> url_request_;
« no previous file with comments | « no previous file | chromecast/net/connectivity_checker_impl.cc » ('j') | chromecast/net/connectivity_checker_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698