third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObject.h - Issue 1974713003: Speed up fix for expando-loss conformance test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObject.h

Issue 1974713003: Speed up fix for expando-loss conformance test. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review feedback from haraken. Use phantom persistents. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObject.h

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObject.h b/third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObject.h

index 9ea18e22fe8791ab59360b755063574ae15cb862..f1b8b1d3ef40d1665b34f676b755d21b0bc65487 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObject.h

+++ b/third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObject.h

@@ -16,6 +16,10 @@ public:

private:

explicit WebGLVertexArrayObject(WebGLRenderingContextBase*, VaoType);

+ // For preserving the wrappers of WebGLBuffer objects latched in

+ // via vertexAttribPointer calls.

+ v8::Persistent<v8::Array> m_bufferWrappers;

};

} // namespace blink