third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp - Issue 1974713003: Speed up fix for expando-loss conformance test.

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp

Issue 1974713003: Speed up fix for expando-loss conformance test. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add V8CopyablePersistent alias to avoid incorrect usage. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.h ('k') | third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h » ('j') | third_party/WebKit/Source/modules/webgl/WebGLObject.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp

diff --git a/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp b/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp

index c08894676e64ac7f5e89cde36dc97f97f6ab7de3..a7cfc3896670a4f65b47e5fde6b9d8f8536a7328 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp

+++ b/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp

@@ -321,11 +321,11 @@ void WebGL2RenderingContextBase::framebufferTextureLayer(ScriptState* scriptStat

// We divide it here so in WebGLFramebuffer, we don't have to handle DEPTH_STENCIL_ATTACHMENT in WebGL 2.

framebufferBinding->setAttachmentForBoundFramebuffer(target, GL_DEPTH_ATTACHMENT, textarget, texture, level, layer);

framebufferBinding->setAttachmentForBoundFramebuffer(target, GL_STENCIL_ATTACHMENT, textarget, texture, level, layer);

- preserveObjectWrapper(scriptState, framebufferBinding, "attachment", GL_DEPTH_ATTACHMENT, texture);

- preserveObjectWrapper(scriptState, framebufferBinding, "attachment", GL_STENCIL_ATTACHMENT, texture);

+ preserveObjectWrapper(scriptState, framebufferBinding, V8HiddenValue::webglAttachments(scriptState->isolate()), framebufferBinding->getPersistentCache(), GL_DEPTH_ATTACHMENT, texture);

+ preserveObjectWrapper(scriptState, framebufferBinding, V8HiddenValue::webglAttachments(scriptState->isolate()), framebufferBinding->getPersistentCache(), GL_STENCIL_ATTACHMENT, texture);

} else {

framebufferBinding->setAttachmentForBoundFramebuffer(target, attachment, textarget, texture, level, layer);

- preserveObjectWrapper(scriptState, framebufferBinding, "attachment", attachment, texture);

+ preserveObjectWrapper(scriptState, framebufferBinding, V8HiddenValue::webglAttachments(scriptState->isolate()), framebufferBinding->getPersistentCache(), attachment, texture);

}

applyStencilTest();

}

@@ -2717,8 +2717,9 @@ void WebGL2RenderingContextBase::bindFramebuffer(ScriptState* scriptState, GLenu

}

setFramebuffer(target, buffer);

- if (scriptState)

- preserveObjectWrapper(scriptState, this, "framebuffer", 0, buffer);

+ if (scriptState) {

+ preserveObjectWrapper(scriptState, this, V8HiddenValue::webglMisc(scriptState->isolate()), &m_miscWrappers, static_cast<uint32_t>(PreservedFramebuffer), buffer);

+ }

}

void WebGL2RenderingContextBase::deleteFramebuffer(WebGLFramebuffer* framebuffer)