Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Side by Side Diff: third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h

Issue 1974713003: Speed up fix for expando-loss conformance test. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add V8CopyablePersistent alias to avoid incorrect usage. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Apple Inc. All rights reserved. 2 * Copyright (C) 2009 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
87 87
88 // Wrapper for drawBuffersEXT/drawBuffersARB to work around a driver bug. 88 // Wrapper for drawBuffersEXT/drawBuffersARB to work around a driver bug.
89 void drawBuffers(const Vector<GLenum>& bufs); 89 void drawBuffers(const Vector<GLenum>& bufs);
90 90
91 GLenum getDrawBuffer(GLenum); 91 GLenum getDrawBuffer(GLenum);
92 92
93 void readBuffer(const GLenum colorBuffer) { m_readBuffer = colorBuffer; } 93 void readBuffer(const GLenum colorBuffer) { m_readBuffer = colorBuffer; }
94 94
95 GLenum getReadBuffer() const { return m_readBuffer; } 95 GLenum getReadBuffer() const { return m_readBuffer; }
96 96
97 V8CopyablePersistent<v8::Array>* getPersistentCache();
98
97 DECLARE_VIRTUAL_TRACE(); 99 DECLARE_VIRTUAL_TRACE();
98 100
99 protected: 101 protected:
100 explicit WebGLFramebuffer(WebGLRenderingContextBase*); 102 explicit WebGLFramebuffer(WebGLRenderingContextBase*);
101 103
102 bool hasObject() const override { return m_object != 0; } 104 bool hasObject() const override { return m_object != 0; }
103 void deleteObjectImpl(gpu::gles2::GLES2Interface*) override; 105 void deleteObjectImpl(gpu::gles2::GLES2Interface*) override;
104 106
105 private: 107 private:
106 WebGLAttachment* getAttachment(GLenum attachment) const; 108 WebGLAttachment* getAttachment(GLenum attachment) const;
(...skipping 13 matching lines...) Expand all
120 122
121 AttachmentMap m_attachments; 123 AttachmentMap m_attachments;
122 bool m_destructionInProgress; 124 bool m_destructionInProgress;
123 125
124 bool m_hasEverBeenBound; 126 bool m_hasEverBeenBound;
125 127
126 Vector<GLenum> m_drawBuffers; 128 Vector<GLenum> m_drawBuffers;
127 Vector<GLenum> m_filteredDrawBuffers; 129 Vector<GLenum> m_filteredDrawBuffers;
128 130
129 GLenum m_readBuffer; 131 GLenum m_readBuffer;
132
133 V8CopyablePersistent<v8::Array> m_attachmentWrappers;
130 }; 134 };
131 135
132 } // namespace blink 136 } // namespace blink
133 137
134 #endif // WebGLFramebuffer_h 138 #endif // WebGLFramebuffer_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698