[MD History] Unify query state in history-app.

chrome/test/data/webui/md_history/history_item_test.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('md_history.history_item_test', function() {
   function registerTests() {
     suite('history-item', function() {
       var element;
       var TEST_HISTORY_RESULTS;
       var SEARCH_HISTORY_RESULTS;
@@ skipping 10 matching lines @@
         ];
 
         SEARCH_HISTORY_RESULTS = [
           createSearchEntry('2016-03-16', "http://www.google.com"),
           createSearchEntry('2016-03-14', "http://calendar.google.com"),
           createSearchEntry('2016-03-14', "http://mail.google.com")
         ];
       });
 
       test('basic separator insertion', function(done) {
-        element.addNewResults(TEST_HISTORY_RESULTS, '');
+        element.addNewResults(TEST_HISTORY_RESULTS);
         flush(function() {
           // Check that the correct number of time gaps are inserted.
           var items =
               Polymer.dom(element.root).querySelectorAll('history-item');
 
           assertTrue(items[0].hasTimeGap);
           assertTrue(items[1].hasTimeGap);
           assertFalse(items[2].hasTimeGap);
           assertTrue(items[3].hasTimeGap);
           assertFalse(items[4].hasTimeGap);
           assertFalse(items[5].hasTimeGap);
 
           done();
         });
       });
 
       test('separator insertion for search', function(done) {
-        element.addNewResults(SEARCH_HISTORY_RESULTS, 'search');
+        element.addNewResults(SEARCH_HISTORY_RESULTS);
+        element.searchedTerm = 'search';

[tsergeant, 2016/05/13 03:41:06]

Related to previous question, is searchedTerm expected to be set before
addNewResults?

searchedTerm is necessary for needsTimeGap_, which is computed when the
iron-list updates...and it's unclear whether that is done immediately or
deferred.

Even if the way you've written it here is correct, there's the possibility for
this test to give a false positive (It would be pass even if searchTerm == ''),
so we should probably fix that.

[calamity, 2016/05/18 01:41:52]

Fixed this test.

         flush(function() {
           var items =
               Polymer.dom(element.root).querySelectorAll('history-item');
 
           assertTrue(items[0].hasTimeGap);
           assertFalse(items[1].hasTimeGap);
           assertFalse(items[2].hasTimeGap);
 
           done();
         });
       });
 
       test('separator insertion after deletion', function(done) {
-        element.addNewResults(TEST_HISTORY_RESULTS, '');
+        element.addNewResults(TEST_HISTORY_RESULTS);
         flush(function() {
           var items =
               Polymer.dom(element.root).querySelectorAll('history-item');
 
           element.set('historyData.3.selected', true);
           items[3].onCheckboxSelected_();
 
           element.removeDeletedHistory(1);
           assertEquals(element.historyData.length, 5);
 
           // Checks that a new time gap separator has been inserted.
           assertTrue(items[2].hasTimeGap);
 
           element.set('historyData.3.selected', true);
           items[3].onCheckboxSelected_();
           element.removeDeletedHistory(1);
 
           // Checks time gap separator is removed.
           assertFalse(items[2].hasTimeGap);
           done();
         });
       });
 
       teardown(function() {
         element.historyData = [];
+        element.searchedTerm = '';
       });
     });
   }
   return {
     registerTests: registerTests
   };
 });