Make Visitor use heap for the current thread

Make Visitor use heap for the current thread

BUG=591606
Committed: https://crrev.com/46e7122b5d91f6b0a12e8cf16eb5ea3e6bb64f63
Cr-Commit-Position: refs/heads/master@{#394718}

[keishi, 2016-05-18 12:41:53]

Description was changed from

==========
oldvisitor

BUG=
==========

to

==========
Make Visitor use heap for the current thread

BUG=591606
==========

[keishi, 2016-05-18 12:53:24]

keishi@chromium.org changed reviewers:
+ haraken@chromium.org, oilpan-reviews@chromium.org

[keishi, 2016-05-18 12:53:25]

This CL uses ThreadState::heap() to access the ThreadHeap from the Visitor.

This had performance concern so I also made a version that uses templated
Visitor to access the mainThreadHeap directly. 
https://codereview.chromium.org/1909803002/

After running benchmarks I don't see actual regressions in either version (the
regressions seem to be flaky) so I would like to go with this CL.

Compares ToT vs codereview.chromium.org/1909803002 vs this CL.
http://www.googledrive.com/host/0BwRi59l_ri74cGtvQ2VYazNzN3c/tot-vs-oldvisito...

[haraken, 2016-05-18 13:03:01]

LGTM. Let's try.

https://codereview.chromium.org/1974693002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/heap/InlinedGlobalMarkingVisitor.h
(right):

https://codereview.chromium.org/1974693002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/heap/InlinedGlobalMarkingVisitor.h:19:
InlinedGlobalMarkingVisitor(ThreadState* state) : VisitorHelper(state) { }

Add explicit.

[keishi, 2016-05-19 02:35:32]

https://codereview.chromium.org/1974693002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/heap/InlinedGlobalMarkingVisitor.h
(right):

https://codereview.chromium.org/1974693002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/heap/InlinedGlobalMarkingVisitor.h:19:
InlinedGlobalMarkingVisitor(ThreadState* state) : VisitorHelper(state) { }
On 2016/05/18 13:03:01, haraken wrote:
> 
> Add explicit.

Done.

[keishi, 2016-05-19 02:35:47]

The CQ bit was checked by keishi@chromium.org

[keishi, 2016-05-19 02:35:48]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/1974693002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-05-19 02:36:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1974693002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1974693002/40001

[commit-bot: I haz the power, 2016-05-19 03:02:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-19 03:02:34]

Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[keishi, 2016-05-19 05:10:53]

The CQ bit was checked by keishi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-19 05:11:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1974693002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1974693002/60001

[commit-bot: I haz the power, 2016-05-19 05:57:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-19 05:57:18]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[keishi, 2016-05-19 07:12:26]

The CQ bit was checked by keishi@chromium.org

[keishi, 2016-05-19 07:12:26]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/1974693002/#ps80001
(title: " ")

[commit-bot: I haz the power, 2016-05-19 07:12:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1974693002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1974693002/80001

[commit-bot: I haz the power, 2016-05-19 08:39:26]

Description was changed from

==========
Make Visitor use heap for the current thread

BUG=591606
==========

to

==========
Make Visitor use heap for the current thread

BUG=591606
==========

[commit-bot: I haz the power, 2016-05-19 08:39:27]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-05-19 08:41:20]

Description was changed from

==========
Make Visitor use heap for the current thread

BUG=591606
==========

to

==========
Make Visitor use heap for the current thread

BUG=591606

Committed: https://crrev.com/46e7122b5d91f6b0a12e8cf16eb5ea3e6bb64f63
Cr-Commit-Position: refs/heads/master@{#394718}
==========

[commit-bot: I haz the power, 2016-05-19 08:41:21]

Patchset 5 (id:??) landed as
https://crrev.com/46e7122b5d91f6b0a12e8cf16eb5ea3e6bb64f63
Cr-Commit-Position: refs/heads/master@{#394718}