Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1974683005: sync compositor: Async scroll offset IPC (Closed)

Created:
4 years, 7 months ago by boliu
Modified:
4 years, 7 months ago
Reviewers:
hush (inactive), dcheng
CC:
chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

sync compositor: Async scroll offset IPC Take browser initiated scroll out of SyncCompositorCommonBrowserParams into its own async IPC. BUG=609977 Committed: https://crrev.com/22cdc6dc230bf01c7ce0f9b79e7698749892a794 Cr-Commit-Position: refs/heads/master@{#393610}

Patch Set 1 #

Patch Set 2 : early out #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -21 lines) Patch
M content/browser/android/synchronous_compositor_host.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/android/synchronous_compositor_host.cc View 3 chunks +2 lines, -8 lines 0 comments Download
M content/common/android/sync_compositor_messages.h View 3 chunks +2 lines, -4 lines 0 comments Download
M content/common/android/sync_compositor_messages.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/android/synchronous_compositor_proxy.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/android/synchronous_compositor_proxy.cc View 1 3 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
boliu
ptal dcheng for ipc hush for the rest
4 years, 7 months ago (2016-05-13 16:56:56 UTC) #2
dcheng
lgtm
4 years, 7 months ago (2016-05-13 17:43:15 UTC) #3
hush (inactive)
lgtm
4 years, 7 months ago (2016-05-13 18:52:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1974683005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1974683005/20001
4 years, 7 months ago (2016-05-13 18:53:30 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-13 19:43:25 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 19:44:36 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/22cdc6dc230bf01c7ce0f9b79e7698749892a794
Cr-Commit-Position: refs/heads/master@{#393610}

Powered by Google App Engine
This is Rietveld 408576698