Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 197463003: Revert 256579 "Allow the content browser client to specify a spe..." (Closed)

Created:
6 years, 9 months ago by Peter Beverloo
Modified:
6 years, 9 months ago
Reviewers:
tburkard
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 256579 "Allow the content browser client to specify a spe..." This broke the Android builders. The try-bots on the CL did point out the compile errors, but it was committed manually anyway. Logs: http://build.chromium.org/p/chromium.linux/builders/Android%20Clang%20Builder%20%28dbg%29/builds/30977/steps/compile/logs/stdio > Allow the content browser client to specify a special cookie store to be > used for a given render process id. This special cookie store will then > be used for renderer messages pertaining to cookies, url fetches in net, > and websockets. If the special cookie store is NULL, a default cookie store > will be used. > > R=erikwright@chromium.org, jam@chromium.org, lambroslambrou@chromium.org, mmenke@chromium.org, tyoshino@chromium.org > > Review URL: https://codereview.chromium.org/188693003 TBR=tburkard@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256583

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+204 lines, -336 lines) Patch
M trunk/src/chrome/browser/net/chrome_fraudulent_certificate_reporter.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/net/connection_tester.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/net/http_pipelining_compatibility_client.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/chrome/browser/plugins/plugin_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/ssl/ssl_client_certificate_selector_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/ui/views/ssl_client_certificate_selector_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/browser/download/download_manager_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/browser/fileapi/blob_url_request_job_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/browser/fileapi/file_system_dir_url_request_job_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/browser/fileapi/file_system_url_request_job_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/browser/fileapi/file_writer_delegate_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/content/browser/loader/resource_dispatcher_host_impl.cc View 2 chunks +2 lines, -10 lines 0 comments Download
M trunk/src/content/browser/loader/resource_scheduler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/browser/renderer_host/render_message_filter.h View 2 chunks +2 lines, -3 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_message_filter.cc View 7 chunks +17 lines, -36 lines 0 comments Download
M trunk/src/content/browser/renderer_host/socket_stream_dispatcher_host.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/content/browser/renderer_host/socket_stream_host.h View 2 chunks +0 lines, -2 lines 0 comments Download
M trunk/src/content/browser/renderer_host/socket_stream_host.cc View 4 chunks +3 lines, -8 lines 0 comments Download
M trunk/src/content/browser/streams/stream_url_request_job_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/content/public/browser/content_browser_client.h View 2 chunks +0 lines, -7 lines 0 comments Download
M trunk/src/content/public/browser/content_browser_client.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M trunk/src/net/proxy/proxy_script_fetcher_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/net/socket_stream/socket_stream.h View 6 chunks +4 lines, -11 lines 0 comments Download
M trunk/src/net/socket_stream/socket_stream.cc View 5 chunks +23 lines, -33 lines 0 comments Download
M trunk/src/net/socket_stream/socket_stream_job.h View 5 chunks +5 lines, -11 lines 0 comments Download
M trunk/src/net/socket_stream/socket_stream_job.cc View 3 chunks +2 lines, -10 lines 0 comments Download
M trunk/src/net/socket_stream/socket_stream_job_manager.h View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/net/socket_stream/socket_stream_job_manager.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M trunk/src/net/socket_stream/socket_stream_unittest.cc View 18 chunks +44 lines, -37 lines 0 comments Download
M trunk/src/net/url_request/url_fetcher_core.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/net/url_request/url_request.h View 5 chunks +0 lines, -24 lines 0 comments Download
M trunk/src/net/url_request/url_request.cc View 2 chunks +31 lines, -51 lines 0 comments Download
M trunk/src/net/url_request/url_request_context.h View 1 chunk +1 line, -5 lines 0 comments Download
M trunk/src/net/url_request/url_request_context.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M trunk/src/net/url_request/url_request_http_job.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M trunk/src/net/url_request/url_request_job.h View 2 chunks +0 lines, -4 lines 0 comments Download
M trunk/src/net/url_request/url_request_job.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M trunk/src/net/websockets/websocket_job.cc View 4 chunks +6 lines, -7 lines 0 comments Download
M trunk/src/net/websockets/websocket_job_test.cc View 5 chunks +7 lines, -8 lines 0 comments Download
M trunk/src/net/websockets/websocket_throttle_test.cc View 9 chunks +18 lines, -9 lines 0 comments Download
M trunk/src/remoting/host/token_validator_factory_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/webkit/browser/appcache/appcache_storage_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/webkit/browser/appcache/appcache_update_job.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/webkit/browser/appcache/appcache_url_request_job_unittest.cc View 4 chunks +4 lines, -8 lines 0 comments Download
M trunk/src/webkit/browser/blob/blob_url_request_job_factory.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Peter Beverloo
6 years, 9 months ago (2014-03-12 18:21:21 UTC) #1
Peter Beverloo
6 years, 9 months ago (2014-03-12 18:23:08 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r256583 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698