Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 197463002: Add a WebRuntimeFeature for will-change (Closed)

Created:
6 years, 9 months ago by ajuma
Modified:
6 years, 9 months ago
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium, ernstm, Vangelis Kokkevis
Visibility:
Public.

Description

Make BleedingEdgeFastPaths imply will-change This enables the CSSWillChange RuntimeEnabledFeature when the BleedingEdgeFastPaths WebRuntimeFeature is enabled. BUG=313532 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169077

Patch Set 1 #

Patch Set 2 : Make BleedingEdgeFastPaths imply will-change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M Source/web/WebRuntimeFeatures.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
ajuma
The chromium side of this change is http://crrev.com/197473002.
6 years, 9 months ago (2014-03-12 14:26:49 UTC) #1
abarth-chromium
Why do we need a separate API for this setting? CSSWillChange status=experimental means it's controlled ...
6 years, 9 months ago (2014-03-12 19:30:07 UTC) #2
nduca
so it seems like will-change should be on when --experimental-web-platform-features is on. question is, bleeding-edge-fast-paths ...
6 years, 9 months ago (2014-03-12 19:41:40 UTC) #3
ajuma
PTAL. I've updated this CL so that instead of adding a new WebRuntimeFeature, the existing ...
6 years, 9 months ago (2014-03-12 20:11:51 UTC) #4
chrishtr
lgtm
6 years, 9 months ago (2014-03-12 20:13:10 UTC) #5
abarth-chromium
lgtm
6 years, 9 months ago (2014-03-12 21:26:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajuma@chromium.org/197463002/20001
6 years, 9 months ago (2014-03-12 21:26:23 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-12 21:31:34 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_blink_rel
6 years, 9 months ago (2014-03-12 21:31:35 UTC) #9
ajuma
The CQ bit was checked by ajuma@chromium.org
6 years, 9 months ago (2014-03-12 21:32:26 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajuma@chromium.org/197463002/20001
6 years, 9 months ago (2014-03-12 21:32:29 UTC) #11
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 9 months ago (2014-03-12 21:32:42 UTC) #12
commit-bot: I haz the power
6 years, 9 months ago (2014-03-13 02:19:52 UTC) #13
Message was sent while issue was closed.
Change committed as 169077

Powered by Google App Engine
This is Rietveld 408576698