Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: src/codegen.cc

Issue 1974623002: Remove AstNode::PrettyPrint, --print-source, and --print-builtin-source (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebased Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ast/prettyprinter.cc ('k') | src/compiler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/codegen.cc
diff --git a/src/codegen.cc b/src/codegen.cc
index 4597ae27669a4954ea1d7c841497dec6be0142af..2c0bfba1ccefae81c44309c5c85515f41d8ff44a 100644
--- a/src/codegen.cc
+++ b/src/codegen.cc
@@ -84,32 +84,24 @@ Comment::~Comment() {
void CodeGenerator::MakeCodePrologue(CompilationInfo* info, const char* kind) {
- bool print_source = false;
bool print_ast = false;
const char* ftype;
if (info->isolate()->bootstrapper()->IsActive()) {
- print_source = FLAG_print_builtin_source;
print_ast = FLAG_print_builtin_ast;
ftype = "builtin";
} else {
- print_source = FLAG_print_source;
print_ast = FLAG_print_ast;
ftype = "user-defined";
}
- if (FLAG_trace_codegen || print_source || print_ast) {
+ if (FLAG_trace_codegen || print_ast) {
base::SmartArrayPointer<char> name = info->GetDebugName();
PrintF("[generating %s code for %s function: %s]\n", kind, ftype,
name.get());
}
#ifdef DEBUG
- if (info->parse_info() && print_source) {
- PrintF("--- Source from AST ---\n%s\n",
- PrettyPrinter(info->isolate()).PrintProgram(info->literal()));
- }
-
if (info->parse_info() && print_ast) {
PrintF("--- AST ---\n%s\n",
AstPrinter(info->isolate()).PrintProgram(info->literal()));
« no previous file with comments | « src/ast/prettyprinter.cc ('k') | src/compiler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698