Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 1974623002: Remove AstNode::PrettyPrint, --print-source, and --print-builtin-source (Closed)

Created:
4 years, 7 months ago by adamk
Modified:
4 years, 5 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com, oth, rmcilroy, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove AstNode::PrettyPrint, --print-source, and --print-builtin-source The PrettyPrinter may have been valuable once, but with all the desugaring now done in the parser the output is far from readable, and for some nodes it's next-to-impossible to recreate the source from the AST. --print-ast is a much more sensible place to look for human-readable info on what the parser did. Committed: https://crrev.com/efefadc6cae692741162fd0440afcabc13888e37 Cr-Commit-Position: refs/heads/master@{#37730}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -642 lines) Patch
M src/ast/ast.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/ast/ast.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M src/ast/prettyprinter.h View 1 3 chunks +12 lines, -41 lines 0 comments Download
M src/ast/prettyprinter.cc View 1 8 chunks +13 lines, -564 lines 0 comments Download
M src/codegen.cc View 1 1 chunk +1 line, -9 lines 0 comments Download
M src/compiler.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M src/compiler.cc View 1 1 chunk +0 lines, -7 lines 0 comments Download
M src/flag-definitions.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M src/interpreter/interpreter.cc View 1 2 chunks +1 line, -9 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Michael Starzinger
LGTM. +1, yes I want this!
4 years, 5 months ago (2016-07-13 12:09:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/1974623002/20001
4 years, 5 months ago (2016-07-13 21:02:17 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-13 21:13:37 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 21:13:38 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 21:14:27 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/efefadc6cae692741162fd0440afcabc13888e37
Cr-Commit-Position: refs/heads/master@{#37730}

Powered by Google App Engine
This is Rietveld 408576698