Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 1974613002: Remove code that was only used by navigator.connect. (Closed)

Created:
4 years, 7 months ago by Marijn Kruisselbrink
Modified:
4 years, 7 months ago
CC:
android-webview-reviews_chromium.org, blink-reviews, blink-reviews-api_chromium.org, blink-reviews-dom_chromium.org, blink-worker-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, eae+blinkwatch, horo+watch_chromium.org, jam, jsbell+serviceworker_chromium.org, kinuko+watch, kinuko+serviceworker, michaeln, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nhiroki, rwlbuis, serviceworker-reviews, sof, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove code that was only used by navigator.connect. All the logic to send messages over MessagePort's as base::Value instances was only used by navigator.connect. So with that API gone, also clean up all the base::Value logic. This more or less reverts https://codereview.chromium.org/944443003 and https://codereview.chromium.org/924983002/. BUG=461906 Committed: https://crrev.com/d27aef56ddecda2e7245808330c1d13bae5fb4ac Cr-Commit-Position: refs/heads/master@{#393589}

Patch Set 1 #

Patch Set 2 : fix android webview build #

Total comments: 1

Patch Set 3 : fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -369 lines) Patch
M android_webview/browser/aw_message_port_message_filter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M android_webview/browser/aw_message_port_message_filter.cc View 1 3 chunks +6 lines, -18 lines 0 comments Download
M android_webview/native/aw_contents.cc View 1 2 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/printing/print_dialog_cloud_win.cc View 2 chunks +1 line, -2 lines 0 comments Download
M content/browser/message_port_message_filter.h View 2 chunks +3 lines, -4 lines 0 comments Download
M content/browser/message_port_message_filter.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/message_port_provider.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/message_port_provider_browsertest.cc View 5 chunks +14 lines, -16 lines 0 comments Download
M content/browser/message_port_service.h View 4 chunks +5 lines, -7 lines 0 comments Download
M content/browser/message_port_service.cc View 6 chunks +12 lines, -12 lines 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host.h View 4 chunks +9 lines, -11 lines 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host_unittest.cc View 4 chunks +13 lines, -15 lines 0 comments Download
M content/browser/service_worker/service_worker_provider_host.h View 1 chunk +3 lines, -4 lines 0 comments Download
M content/browser/service_worker/service_worker_provider_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_version.h View 2 chunks +3 lines, -5 lines 0 comments Download
M content/browser/service_worker/service_worker_version.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/shared_worker/shared_worker_service_impl_unittest.cc View 5 chunks +8 lines, -9 lines 0 comments Download
M content/browser/web_contents/web_contents_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/webmessageportchannel_impl.h View 7 chunks +9 lines, -15 lines 0 comments Download
M content/child/webmessageportchannel_impl.cc View 9 chunks +21 lines, -57 lines 0 comments Download
M content/common/frame_messages.h View 2 chunks +1 line, -2 lines 0 comments Download
M content/common/message_port_messages.h View 4 chunks +5 lines, -17 lines 0 comments Download
M content/common/service_worker/service_worker_messages.h View 5 chunks +4 lines, -5 lines 0 comments Download
M content/common/view_messages.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/content_common.gypi View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/browser/message_port_delegate.h View 2 chunks +2 lines, -4 lines 0 comments Download
M content/public/browser/message_port_provider.h View 3 chunks +3 lines, -5 lines 0 comments Download
D content/public/common/message_port_types.h View 1 chunk +0 lines, -48 lines 0 comments Download
D content/public/common/message_port_types.cc View 1 chunk +0 lines, -46 lines 0 comments Download
M content/renderer/shared_worker/embedded_shared_worker_stub.cc View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/MessagePort.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/MessagePort.cpp View 1 chunk +0 lines, -16 lines 0 comments Download
M third_party/WebKit/public/platform/WebMessagePortChannelClient.h View 1 2 2 chunks +1 line, -17 lines 0 comments Download

Messages

Total messages: 25 (10 generated)
Marijn Kruisselbrink
avi for content/ OWNERS sgurun for android_webview/ OWNERS tsepez for IPC OWNERS haraken for WebKit ...
4 years, 7 months ago (2016-05-12 00:07:09 UTC) #4
Tom Sepez
IPC OWNER LGTM.
4 years, 7 months ago (2016-05-12 00:25:05 UTC) #5
haraken
WebKit/Source/ LGTM
4 years, 7 months ago (2016-05-12 00:38:44 UTC) #6
Avi (use Gerrit)
content lgtm
4 years, 7 months ago (2016-05-12 01:39:25 UTC) #7
kinuko
drive-by lgtm for the part I care about https://codereview.chromium.org/1974613002/diff/40001/third_party/WebKit/public/platform/WebMessagePortChannelClient.h File third_party/WebKit/public/platform/WebMessagePortChannelClient.h (right): https://codereview.chromium.org/1974613002/diff/40001/third_party/WebKit/public/platform/WebMessagePortChannelClient.h#newcode40 third_party/WebKit/public/platform/WebMessagePortChannelClient.h:40: // ...
4 years, 7 months ago (2016-05-12 02:04:47 UTC) #9
sgurun-gerrit only
On 2016/05/12 02:04:47, kinuko wrote: > drive-by lgtm for the part I care about > ...
4 years, 7 months ago (2016-05-12 18:54:26 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1974613002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1974613002/40001
4 years, 7 months ago (2016-05-12 18:59:50 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/182222)
4 years, 7 months ago (2016-05-12 19:10:33 UTC) #14
Marijn Kruisselbrink
+alekseys for chrome/browser/printing OWNERS
4 years, 7 months ago (2016-05-12 19:15:37 UTC) #16
kinuko
Could we fix the comment before landing? On 2016/05/12 02:04:47, kinuko wrote: > https://codereview.chromium.org/1974613002/diff/40001/third_party/WebKit/public/platform/WebMessagePortChannelClient.h > ...
4 years, 7 months ago (2016-05-13 04:43:38 UTC) #17
Marijn Kruisselbrink
On 2016/05/13 at 04:43:38, kinuko wrote: > Could we fix the comment before landing? Oops, ...
4 years, 7 months ago (2016-05-13 15:53:20 UTC) #18
Aleksey Shlyapnikov
lgtm printing lgtm
4 years, 7 months ago (2016-05-13 18:24:23 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1974613002/50001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1974613002/50001
4 years, 7 months ago (2016-05-13 18:25:58 UTC) #22
commit-bot: I haz the power
Committed patchset #3 (id:50001)
4 years, 7 months ago (2016-05-13 18:33:26 UTC) #23
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 18:35:10 UTC) #25
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d27aef56ddecda2e7245808330c1d13bae5fb4ac
Cr-Commit-Position: refs/heads/master@{#393589}

Powered by Google App Engine
This is Rietveld 408576698