Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 19746: Remove old web app code it's no longer needed. Simplifies startup a little. (Closed)

Created:
11 years, 10 months ago by Ben Goodger (Google)
Modified:
9 years, 6 months ago
Reviewers:
brettw
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Remove old web app code it's no longer needed. Simplifies startup a little. Also fixes a regression from the BrowserInit porting work. I was a little over-zealous removing the CommandLine handling. It turns out that it's this that MessageWindow uses to convey the command line of the signalling process to the existing process, and that the existing process re-runs BrowserInit with the signalling process' command line. So I plumbed that back through again. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=9034

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -1006 lines) Patch
M chrome/browser/browser.h View 1 2 3 4 5 chunks +4 lines, -12 lines 0 comments Download
M chrome/browser/browser.cc View 1 2 3 4 5 chunks +7 lines, -44 lines 2 comments Download
M chrome/browser/browser.scons View 3 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/browser.vcproj View 2 chunks +0 lines, -24 lines 0 comments Download
M chrome/browser/browser_init.h View 1 6 chunks +23 lines, -7 lines 0 comments Download
M chrome/browser/browser_init.cc View 1 13 chunks +112 lines, -119 lines 0 comments Download
M chrome/browser/browser_main.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chrome_plugin_host.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/message_window.cc View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/web_contents.h View 6 chunks +2 lines, -25 lines 0 comments Download
M chrome/browser/tab_contents/web_contents.cc View 7 chunks +1 line, -50 lines 0 comments Download
M chrome/browser/views/constrained_window_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/web_app.h View 1 chunk +0 lines, -159 lines 0 comments Download
D chrome/browser/web_app.cc View 1 chunk +0 lines, -281 lines 0 comments Download
D chrome/browser/web_app_icon_manager.h View 1 chunk +0 lines, -58 lines 0 comments Download
D chrome/browser/web_app_icon_manager.cc View 1 chunk +0 lines, -115 lines 0 comments Download
D chrome/browser/web_app_launcher.h View 1 chunk +0 lines, -41 lines 0 comments Download
D chrome/browser/web_app_launcher.cc View 1 chunk +0 lines, -47 lines 0 comments Download
M chrome/chrome.xcodeproj/project.pbxproj View 2 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Ben Goodger (Google)
11 years, 10 months ago (2009-02-02 05:46:30 UTC) #1
brettw
11 years, 10 months ago (2009-02-02 06:26:46 UTC) #2
LGTM

http://codereview.chromium.org/19746/diff/306/58
File chrome/browser/browser.cc (right):

http://codereview.chromium.org/19746/diff/306/58#newcode313
Line 313: const std::wstring& app_name = ComputeApplicationNameFromURL(url);
While not wrong, I think this is better as a std::wstring rather than a const
ref. Since the function returns a real string, you're not saving anything.

http://codereview.chromium.org/19746/diff/306/58#newcode1810
Line 1810: const std::wstring& app_name = ComputeApplicationNameFromURL(url);
Same string comment.

Powered by Google App Engine
This is Rietveld 408576698