Make the launch params the default client behavior for UMA 3g

components/metrics/net/cellular_logic_helper.cc

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/metrics/net/cellular_logic_helper.h"
+
+#include "components/variations/variations_associated_data.h"
+#include "net/base/network_change_notifier.h"
+
+namespace metrics {
+
+// Standard interval between log uploads, in seconds.
+#if defined(OS_ANDROID) || defined(OS_IOS)
+const int kStandardUploadIntervalSeconds = 5 * 60;           // Five minutes.
+const int kStandardUploadIntervalCellularSeconds = 15 * 60;  // Fifteen minutes.
+#else
+const int kStandardUploadIntervalSeconds = 30 * 60;  // Thirty minutes.
+#endif
+
+const bool kDefaultCellularLogicEnabled = true;
+const bool kDefaultCellularLogicOptimization = true;

[Alexei Svitkine (slow), 2016/05/13 18:37:13]

These should be in the anon namespace.

[gayane -on leave until 09-2017, 2016/05/13 19:17:02]

Done.

+
+base::TimeDelta GetUploadInterval() {
+#if defined(OS_ANDROID) || defined(OS_IOS)
+  if (IsCellularLogicEnabled())
+    return base::TimeDelta::FromSeconds(kStandardUploadIntervalCellularSeconds);
+#endif
+  return base::TimeDelta::FromSeconds(kStandardUploadIntervalSeconds);
+}
+
+// Returns true if current connection type is cellular and user is assigned to
+// experimental group for enabled cellular uploads.
+bool IsCellularLogicEnabled() {

[Alexei Svitkine (slow), 2016/05/13 18:37:13]

Should we make this return false when platform is not android/ios?

Otherwise it seems strange that we have an ifdef above on line 24 about it, but
other callers of this function may get a different result.

[gayane -on leave until 09-2017, 2016/05/13 19:17:02]

Done.

+  std::string enabled = variations::GetVariationParamValue(
+      "UMA_EnableCellularLogUpload", "Enabled");
+  std::string optimized = variations::GetVariationParamValue(
+      "UMA_EnableCellularLogUpload", "Optimize");
+  bool is_enabled;
+  if (enabled.empty())
+    is_enabled = kDefaultCellularLogicEnabled;
+  else
+    is_enabled = enabled == "true";

[Alexei Svitkine (slow), 2016/05/13 18:37:13]

Nit: How about this structure:

bool is_enabled = kDefaultCellularLogicEnabled;
if (!enabled.empty())
  is_enabled = (enabled == "true");

Same below.

[gayane -on leave until 09-2017, 2016/05/13 19:17:01]

Done.

+
+  bool is_optimized;
+  if (optimized.empty())
+    is_optimized = kDefaultCellularLogicOptimization;
+  else
+    is_optimized = optimized == "true";
+
+  if (!is_enabled || !is_optimized)
+    return false;
+
+  return net::NetworkChangeNotifier::IsConnectionCellular(
+      net::NetworkChangeNotifier::GetConnectionType());
+}
+} // namespace metrics